Skip to content

fix: FIT-460: Adjust variants and styles of buttons across application for consistency #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ricardoantoniocm
Copy link
Contributor

@ricardoantoniocm ricardoantoniocm commented Jul 29, 2025

Reason for change

This PR aims to fix inconsistencies in the use of the Button component across the application.

Improved areas include:

  • Organization page
  • Invite People
  • Project setting pages
  • Labeling UI

Screenshots

Before:

image image image image image image image

After

image image image image image image image image

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit efff1f5
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/688a279a0015fc0008b8f323
😎 Deploy Preview https://deploy-preview-8058--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Jul 29, 2025
Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit efff1f5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/688a279a3089d90008d334c6
😎 Deploy Preview https://deploy-preview-8058--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit efff1f5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/688a279a8a8df40008a6eb82
😎 Deploy Preview https://deploy-preview-8058--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit efff1f5
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/688a279afa5f98000810979e
😎 Deploy Preview https://deploy-preview-8058--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.90%. Comparing base (38cb7f1) to head (efff1f5).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...c/components/SidePanels/DetailsPanel/Relations.tsx 0.00% 1 Missing ⚠️
...mponents/SidePanels/OutlinerPanel/ViewControls.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8058      +/-   ##
===========================================
- Coverage    70.35%   65.90%   -4.45%     
===========================================
  Files          719      505     -214     
  Lines        51031    33499   -17532     
  Branches      8622     8625       +3     
===========================================
- Hits         35904    22079   -13825     
+ Misses       15124    11417    -3707     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 59.49% <94.73%> (+<0.01%) ⬆️
lsf-integration 55.65% <94.73%> (+0.01%) ⬆️
lsf-unit 9.45% <10.00%> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardoantoniocm ricardoantoniocm self-assigned this Jul 29, 2025
@ricardoantoniocm ricardoantoniocm marked this pull request as ready for review July 29, 2025 19:18
@ricardoantoniocm
Copy link
Contributor Author

ricardoantoniocm commented Jul 30, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 label_studio/users/tests/test_redis_activity.py

@ricardoantoniocm ricardoantoniocm enabled auto-merge (squash) July 30, 2025 14:41
@ricardoantoniocm ricardoantoniocm merged commit 5810001 into develop Jul 30, 2025
44 of 46 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-460/adjust-variants-styles-buttons-across-application branch July 30, 2025 14:42
Gondragos pushed a commit that referenced this pull request Jul 31, 2025
…n for consistency (#8058)

Co-authored-by: robot-ci-heartex <[email protected]>
Co-authored-by: ricardoantoniocm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants