Remove date type for time-based query parameters. #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @sidravi1
Estimate:
Ticket
Fixes: Datetime casting bug
Description
Querying time filterable endpoints such as queries and urgency-queries with intra-day date-time parameters result in query results for the full day being returned. This is as a result of behaviour described here.
When passing datetime objects, the instance check will always pass since datetime is a date subclass. This will then set the date parameters to the start and end of the days respectively.
Local tests are complaining about duplicated CLI args in
core_backend/validation/urgency_detection/conftest.py
. I get this even when running pytest -vv in main, so I'm not sure what I'm missing there. I also attempted amkdocs build
to account for the updated docstrings but I don't notice any changes as a result.Goal
To allow intraday datetimes.
Changes
These changes involve removing date support and relying solely on datetime arguments for these endpoints. This is standard practice.
Future Tasks (optional)
How has this been tested?
The tests have been run and confirmed to pass.
To-do before merge (optional)
Checklist
Fill with
x
for completed.(Delete any items below that are not relevant)