Skip to content

Make toggle button focusable and add aria label to the combo input #15921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 21, 2025
Merged

Make toggle button focusable and add aria label to the combo input #15921

merged 7 commits into from
Jul 21, 2025

Conversation

MonikaKirkova
Copy link
Contributor

Closes #15842

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MonikaKirkova MonikaKirkova added ♿ a11y When the issue or PR is related to accessibility combo aria-support simple-combo version: 20.0.x labels Jun 9, 2025
@MonikaKirkova MonikaKirkova added the ❌ status: awaiting-test PRs awaiting manual verification label Jun 9, 2025
@MonikaKirkova MonikaKirkova requested a review from Lipata June 9, 2025 15:54
@ChronosSF ChronosSF self-requested a review July 1, 2025 08:38
ChronosSF
ChronosSF requested changes Jul 1, 2025
View reviewed changes
ChronosSF
ChronosSF previously approved these changes Jul 11, 2025
View reviewed changes
@MonikaKirkova
Merge branch '20.0.x' of https://github.com/IgniteUI/igniteui-angular …
7450678 
…into mkirkova/feat-combo-toggle-button-20.x
@ChronosSF ChronosSF self-requested a review July 15, 2025 12:24
ChronosSF
ChronosSF previously approved these changes Jul 15, 2025
View reviewed changes
@IvanKitanov17 IvanKitanov17 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 15, 2025
@MonikaKirkova
Merge branch '20.0.x' of https://github.com/IgniteUI/igniteui-angular …
47880a1 
…into mkirkova/feat-combo-toggle-button-20.x
@ChronosSF ChronosSF merged commit df8004e into 20.0.x Jul 21, 2025
4 of 6 checks passed
@ChronosSF ChronosSF deleted the mkirkova/feat-combo-toggle-button-20.x branch July 21, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChronosSF ChronosSF ChronosSF approved these changes

@Lipata Lipata Awaiting requested review from Lipata

Assignees

@IvanKitanov17 IvanKitanov17

Labels
aria-support combo localization simple-combo version: 20.0.x ♿ a11y When the issue or PR is related to accessibility ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MonikaKirkova @ChronosSF @IvanKitanov17