Skip to content

feat(h-grid): update adv filtering schema on row expand #15927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

igdmdimitrov
Copy link
Contributor

@igdmdimitrov igdmdimitrov commented Jun 11, 2025

Closes #15827
Closes #15908

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@igdmdimitrov igdmdimitrov requested a review from gedinakova June 17, 2025 07:38
@gedinakova
Copy link
Contributor

@igdmdimitrov There's an issue when expanding inner levels:

  1. Load HGrid Advanced Filtering dev demo
  2. Expand the first record, then its first child

Result: The following error is thrown in the console:
grid-base.directive.ts:7198 ERROR TypeError: Cannot set properties of undefined (setting 'fields')
at _IgxHierarchicalGridComponent.updateRootGridSchema (hierarchical-grid.component.ts:1292:25)
at Object.next (hierarchical-grid.component.ts:686:18)
at _IgxHierarchicalGridComponent.autogenerateColumns (grid-base.directive.ts:7198:35)

Expected result: No errors

@gedinakova
Copy link
Contributor

As currently setup, the AF dialog cannot be open in HGrid Advanced Filtering dev demo. The following console error is thrown:
ERROR TypeError: Cannot read properties of undefined (reading 'pipeArgs')
at _IgxQueryBuilderTreeComponent.getFormat (query-builder-tree.component.ts:1413:58)
at IgxQueryBuilderTreeComponent_ng_template_11_Conditional_0_Conditional_1_Conditional_10_Conditional_2_Conditional_1_Conditional_1_Template (query-builder-tree.component.html:211:45)
at executeTemplate (debug_node-Dn-GvQJo.mjs:7142:9)
at refreshView (debug_node-Dn-GvQJo.mjs:8887:13)
at detectChangesInView (debug_node-Dn-GvQJo.mjs:9107:9)
at detectChangesInViewIfAttached (debug_node-Dn-GvQJo.mjs:9067:5)
at detectChangesInEmbeddedViews (debug_node-Dn-GvQJo.mjs:9024:13)
at refreshView (debug_node-Dn-GvQJo.mjs:8916:9)
at detectChangesInView (debug_node-Dn-GvQJo.mjs:9107:9)
at detectChangesInViewIfAttached (debug_node-Dn-GvQJo.mjs:9067:5)

@gedinakova
Copy link
Contributor

@igdmdimitrov In the generateSchema method, please uncomment the label & header (I thought this was fixed at some point, but apparently not).
image

@igdmdimitrov igdmdimitrov marked this pull request as ready for review July 7, 2025 07:51
@igdmdimitrov igdmdimitrov requested a review from damyanpetev July 7, 2025 07:52
Copy link
Contributor

@gedinakova gedinakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a Changelog update for this change.

@igdmdimitrov igdmdimitrov requested a review from gedinakova July 17, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants