Skip to content

refactor(input-group): update file upload style implementation #16003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: 20.0.x
Choose a base branch
from

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jun 26, 2025

Closes #15775

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein removed the ❌ status: awaiting-test PRs awaiting manual verification label Jun 26, 2025
@desig9stein desig9stein marked this pull request as ready for review June 26, 2025 11:51
@desig9stein desig9stein marked this pull request as draft July 2, 2025 05:29
@desig9stein desig9stein marked this pull request as ready for review July 3, 2025 11:18
@simeonoff simeonoff added the 💥 status: in-test PRs currently being tested label Jul 7, 2025
@simeonoff
Copy link
Collaborator

@desig9stein Please add the web components file input in the input group sample for comparison.

@simeonoff
Copy link
Collaborator

simeonoff commented Jul 7, 2025

Looks like there's a bug in the Boostrap theme where an additional border appears:

Screenshot 2025-07-07 at 10 59 09

In Fluent, the Browse Button text jumps upon focus:

Screen.Recording.2025-07-07.at.11.02.10.mov

@desig9stein desig9stein requested a review from simeonoff July 7, 2025 12:58
@simeonoff
Copy link
Collaborator

simeonoff commented Jul 10, 2025

@desig9stein The issue in bootstrap is even more severe with the latest commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Group: Align the design of the input type="file" to the one in Ignite UI for Web Components
2 participants