Skip to content

Preventing range selection from triggering when element inside CellTemplate is clicked - 20.0.x #16025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 20.0.x
Choose a base branch
from
Open

Preventing range selection from triggering when element inside CellTemplate is clicked - 20.0.x #16025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a39b7b4
fix(grid): Preventing rangeSelection from element inside cellTemplate
Jul 4, 2025
7b192fe
Merge branch '20.0.x' into ikitanov/fix#15810-20.0.x
kacheshmarova Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions projects/igniteui-angular/src/lib/grids/grid/grid-cell-selection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import {
SelectionWithScrollsComponent,
SelectionWithTransactionsComponent,
CellSelectionNoneComponent,
CellSelectionSingleComponent
CellSelectionSingleComponent,
IgxGridCellTemplateForRangeSelectionComponent
} from '../../test-utils/grid-samples.spec';
import { IgxStringFilteringOperand } from '../../data-operations/filtering-condition';
import { UIInteractions, wait } from '../../test-utils/ui-interactions.spec';
Expand All @@ -26,7 +27,8 @@ describe('IgxGrid - Cell selection #grid', () => {
SelectionWithScrollsComponent,
SelectionWithTransactionsComponent,
CellSelectionNoneComponent,
CellSelectionSingleComponent
CellSelectionSingleComponent,
IgxGridCellTemplateForRangeSelectionComponent
]
}).compileComponents();
}));
Expand Down Expand Up @@ -256,6 +258,23 @@ describe('IgxGrid - Cell selection #grid', () => {
expect(grid.selectedCells.length).toBe(1);
});

it('Should not trigger range selection when CellTemplate is used and the user clicks on element inside it',()=>{
fix = TestBed.createComponent(IgxGridCellTemplateForRangeSelectionComponent);
fix.detectChanges();
grid = fix.componentInstance.grid;
detect = () => grid.cdr.detectChanges();

const selectionChangeSpy = spyOn<any>(grid.rangeSelected, 'emit').and.callThrough();
const cell = grid.gridAPI.get_cell_by_index(1, 'ProductID');
const cellElement = cell.nativeElement;
const span = cellElement.querySelector('span');

expect(span).not.toBeNull();
span.click();
fix.detectChanges();
expect(selectionChangeSpy).not.toHaveBeenCalled();
});

it('Should be able to select range when click on a cell and hold Shift key and click on another Cell', () => {
const firstCell = grid.gridAPI.get_cell_by_index(3, 'HireDate');
const secondCell = grid.gridAPI.get_cell_by_index(1, 'ID');
Expand Down
5 changes: 2 additions & 3 deletions projects/igniteui-angular/src/lib/grids/selection/selection.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ export class IgxGridSelectionService {
if (this.areEqualCollections(currSelection, newSelection)) {
return;
}

const args: IRowSelectionEventArgs = {
owner: this.grid,
oldSelection: currSelection,
Expand Down Expand Up @@ -857,8 +857,7 @@ export class IgxGridSelectionService {
this.pointerEventInGridBody = false;
this.grid.document.body.removeEventListener('pointerup', this.pointerOriginHandler);

const targetTagName = event.target.tagName.toLowerCase();
if (targetTagName !== 'igx-grid-cell' && targetTagName !== 'igx-tree-grid-cell') {
if (!event.target.closest('igx-grid-cell') && !event.target.closest('igx-tree-grid-cell')) {
this.pointerUp(this._lastSelectedNode, this.grid.rangeSelected, true);
}
};
Expand Down
20 changes: 20 additions & 0 deletions projects/igniteui-angular/src/lib/test-utils/grid-samples.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,6 +1414,26 @@ export class IgxGridRowEditingWithoutEditableColumnsComponent extends BasicGridC
public override data = SampleTestData.foodProductData();
}

@Component({
template: `
<igx-grid #grid [data]="data" [primaryKey]="'ProductID'" width="700px" height="400px" [cellSelection]="'multiple'">
<igx-column field="ProductID" header="Product ID">
<ng-template igxCell let-cell="cell" let-val>
<span style="background-color: red;">val</span>
<br>
{{val}}
</ng-template>
</igx-column>
<igx-column field="ReorderLevel" header="Reorder Lever" [dataType]="'number'" [editable]="true" width="100px"></igx-column>
<igx-column field="ProductName" header="Product Name" [dataType]="'string'" width="150px"></igx-column>
<igx-column field="OrderDate" header="Order Date" [dataType]="'date'" width="150px" [editable]="false"></igx-column>
</igx-grid>`,
imports: [IgxGridComponent, IgxColumnComponent, IgxCellTemplateDirective]
})
export class IgxGridCellTemplateForRangeSelectionComponent extends BasicGridComponent {
public override data = SampleTestData.foodProductData();
}

@Component({
template: `
<igx-grid #grid [data]="data" [primaryKey]="'ID'" width="700px" height="400px" [rowEditable]="true" [moving]="true">
Expand Down
Loading