Update conditional cell styling topic for React 19 #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the |
|
Probably a good idea if you refactor the methods to be anonymous lambdas to refactor all of them (there a couple that are still functions in the |
mddragnev
requested changes
May 8, 2025
There was a problem hiding this comment.
In Hgrid Using Cell Classes there is :
cellClasses={this.grammyNominationsCellClassesHandler} which is a class component thing. However, every other snippet is using functions. Could you please change that? (Note that the handler is using public access modifier.
| @@ -1105,13 +1105,13 @@ let backgroundClasses = { | |||
| } | |||
| }; | |||
|
|
|||
| function editDone(grid, evt) { | |||
| const editDone = (evt) => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.