feature: use watch instead of client get in Reconciler #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
googs1025
force-pushed
the
feature/configmaps_watch
branch
from
717b0f5 to
2a2a44b
Compare
|
wait for : #443 |
googs1025
force-pushed
the
feature/configmaps_watch
branch
4 times, most recently
from
d7f70e4 to
957a98a
Compare
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
feature/configmaps_watch
branch
from
957a98a to
fa5ab4b
Compare
googs1025
commented
Jul 3, 2025
| @@ -160,9 +161,39 @@ func (r *ServiceReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| return !reflect.DeepEqual(oldBar.Status, newBar.Status) | |||
| }, | |||
| })). | |||
| Watches(&corev1.ConfigMap{}, handler.EnqueueRequestsFromMapFunc(r.updateGlobalConfig), | |||
There was a problem hiding this comment.
We use watch instead of getting configmap every loop, which reduces calls to the api-server.
|
will review tonight. |
|
/lgtm Thanks! |
InftyAI-Agent
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #431 (comment)
Special notes for your reviewer
Does this PR introduce a user-facing change?