Skip to content

Stats: Display placeholders, defaults and help #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Dec 4, 2018

image

@bernhardreiter
Copy link
Member

bernhardreiter commented Dec 17, 2018

Hi @wagner-certat, thanks for the pull request!

  • Because I've looked at merged ENH: Stats: Show label for subqueries instead of key #69 first with a fix, this one does not fully merge anymore
    as allowedSubs has been changed. I did not see that you were using this here. Sorry about this.
    (for testing you could change allowedSubs back to a dict and do the sorting in the v-for loop directly).

  • I've also noticed that https://github.com/Intevation/intelmq-fody-backend/pull/19/files does not contain default values. Where does the default value come from?

  • removeFilter() is missing?

  • The '?' is a button, but the click does not do anything, a tooltip possibly should be over the input field itself?

Sebastian Wagner added 2 commits March 18, 2019 15:16
Changes in the structure of allowedSubs made changes in the function
handling the default, placeholder and help values necessary.
@ghost
Copy link
Author

ghost commented Mar 18, 2019

* Because I've looked at merged #69 first with a fix, this one does not fully merge anymore
  as `allowedSubs` has been changed. I did not see that you were using this here. Sorry about this.
  (for testing you could change `allowedSubs` back to a dict and do the sorting in the v-for loop directly).

I did the merges and adapted the code as bf22e6b changed the allowedSubs from a handy object with the itms to a list of lists with the actual items as object.

* I've also noticed that https://github.com/Intevation/intelmq-fody-backend/pull/19/files does not contain default values. Where does the `default` value come from?

It's optional of course. I don't have a good universal example at hand for it's usage though.

* `removeFilter()` is missing?

That's a change upstream, I removed change this now - it's no longer necessary.

* The '?' is a button, but the click does not do anything, a tooltip possibly should be over the input field itself?

That was the easiest for me to implement and I also think it is very obvious and intuitive for the users when they want to have some help. I removed this now and used the input field itself, which does not work. If you have an idea how to show this, please let me know.

@bernhardreiter
Copy link
Member

Showing the help text should be possible by using a popup when hovering over the field, I'll have to look it up how to do it, though. (And we currently do not have much contracted time to work on this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant