Low Budget Hash Map #432
Merged
Low Budget Hash Map #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanPhilippeKernel
requested changes
Mar 30, 2025
Comment on lines
28
to
33
| array.init(&arena, 4); | ||
| array.push(1); | ||
| array.push(2); | ||
| array.push(3); | ||
| array.push(4); | ||
|
|
There was a problem hiding this comment.
I'd expect the initializer_list to be used for this particular case:
e.g
cpp Array<int> array; array.init(&arena, 4, {1, 2, 3, 4})
There was a problem hiding this comment.
The issue is that {1, 2, 3, 4} syntax is special in C++ - it's directly tied to std::initializer_list but i can have a make_initializer_list variadic function as a helper
Comment on lines
51
to
55
| Array<String> str_array; | ||
| str_array.init(&arena, 3); | ||
| str_array.push(String()); | ||
| str_array.push(String()); | ||
| str_array.push(String()); |
There was a problem hiding this comment.
Same comment about the expectation above
JeanPhilippeKernel
requested changes
Mar 30, 2025
JeanPhilippeKernel
approved these changes
Apr 6, 2025
JeanPhilippeKernel
added
area-window
JeanPhilippeKernel
merged commit c8863dd
into
JeanPhilippeKernel:arena-integration
17 checks passed
JeanPhilippeKernel
added a commit
that referenced
this pull request
Apr 21, 2025
* basic arena allocator (#425) * basic arena allocator * added resize impl * edit resize --------- Co-authored-by: jnyfah <[email protected]> * Introducing Memory Manager (#426) * basic arena allocator * added resize impl * edit resize * added memory manager * updated CI * fixed format * fixed naming * assert PoolAllocator memory --------- Co-authored-by: jnyfah <[email protected]> * added support of cmd parser (#427) (#428) * Containers (#429) * vector and string view draft * string * minor changes * container rewrite * again * more changes * more changes again * Moving Editor to Arena (#430) * initial move to arena * initial editor move to arena alloc * More update around the editor (#431) * initial move to arena * initial editor move to arena alloc * more arena for importers and serializers * cleanup around the editor * fixed scene name * format * improved importers and serializers concurrency * Low Budget Hash Map (#432) * hash map???? * because format is my worst enemy * removing size from array initialization because i dont see the point of it * adding some string to hashmap test because why not * added initializer list and some tests for arrayview * some changes * make lists?? * clang format hates me * remove silly comments * first iteration - engine runs on Arena (#433) * first iteration - engine runs on Arena * fixed input devices * fixed logger configuration logic * fixed vma mem leaks * deleted stale memory in Handle manager pool * fixed handle tests * more removal of vector * clang format * I broke the pipeline --------- Co-authored-by: Jennifer Chukwu <[email protected]> * More removal of std containers (#435) * removed std containers * rewrote the hashmap using linear probing * clang format hates to see me coming lol * more improvement * more improve around shader caches * deleted dead codes * improved corewindows requiredlayers --------- Co-authored-by: jnyfah <[email protected]> * Fixing import model and serialization logic (#442) * fixed import models * fixed platform backslash * Math Library (#440) * vec again * some major changes * clang format * added header * from vector to vec * some changes * some changes again * last one --------- Co-authored-by: jnyfah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need to be revisited in the nearest future as dynamic growth means rehashing the entire hashmap again (hopefully for now that doesn't happen too often as the size doubles and the user also specifies capacity upfront)
Also removed size initialization from array init
Added initializer list