[JEWEL-819] Fix markdown delete row indexes #3051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was caused by incorectly selecting a range from 0 to 0 of edited blocks which resulted in ignoring chars before the first block. Allowing edit computation to start from -1 removes this problem.
|
Any chance you could add a short recap of the fix in the PR description? |
rock3r
reviewed
May 19, 2025
...rc/test/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessorOptimizeEditsTest.kt
Outdated
Show resolved
Hide resolved
obask
force-pushed
the
fix-mardown-delete-row-indexes
branch
from
964fc2c to
71ca1c2
Compare
It made some changes to the UI package. I assume it's ok to include these into my change? |
|
That's fine. It's probably something that was supposed to be fixed on master, but slipped through because the TeamCity CI does not run Gradle checks yet (see JEWEL-800). |
obask
force-pushed
the
fix-mardown-delete-row-indexes
branch
2 times, most recently
from
ec2ed30 to
0f44adb
Compare
obask
commented
May 19, 2025
...l/markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Show resolved
Hide resolved
obask
force-pushed
the
fix-mardown-delete-row-indexes
branch
from
0f44adb to
e31cde9
Compare
rock3r
approved these changes
May 19, 2025
There was a problem hiding this comment.
LGTM for what I can understand of the logic, and seems to work fine when tested, but leaving to @AlexVanGogen to confirm
added 2 commits
May 19, 2025 11:37
...such as inserting a line between paragraphs. Also use more uniform indexes to represent after block position even if it points to the element of a list following the last.
obask
force-pushed
the
fix-mardown-delete-row-indexes
branch
from
e31cde9 to
c3f69d9
Compare
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two separate changes:
1. Minimal Fix for inserts after Leading Whitespace in JEWEL-819:
The first change addresses a bug caused by leading whitespace before the first block. Previously, this whitespace was ignored, resulting in an incomplete string being selected for the updated text.
The fix allows the index of the first edited block to start from -1. This effectively treats leading whitespace as space between blocks, ensuring correct selection. A regression test has been added to verify this behavior.
2. Normalization of End Range Indexing:
The second change applies a similar idea to how end range indexes are interpreted. End indexes are now always positioned after the last character of the corresponding block(or an edited space between blocks). This means they may point just beyond the last element in a list, improving consistency when referencing “after block” positions.
This update relies on the source span length to compute a precise end index position(assuming these are correct).
New tests have been added to cover several edge cases:
Inserting a line between paragraphs,
Inserting a character at the end of a paragraph, Between two paragraphs, At the start of the second paragraph.