[JEWEL-829] Fix the bridge not reading the LaF #3062
Closed
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JEWEL-558, a change was made to add a new flow to the combine in SwingBridgeService. However, that new flow never emitted, causing the whole combine to stall until it did. This in turn causes only the theme defaults to be loaded, until the user changes the "contrast scrollbars" option, making the faulty flow emit, and unblocking the combine. The fix is to ensure the flow emits on start, like all other flows in the `combine` do.
jakub-senohrabek
approved these changes
May 30, 2025
|
Ready to merge |
1 similar comment
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JEWEL-558, a change was made to add a new flow to the combine in
SwingBridgeService. However, that new flow never emitted, causing the wholecombineto stall until it did. This in turn causes only the theme defaults to be loaded, until the user changes the "contrast scrollbars" option, making the faulty flow emit and unblocking thecombine.The fix is to ensure the flow emits on start, like all other flows in the
combinedo.