Skip to content

Conversation

JSMonk
Copy link
Member

@JSMonk JSMonk commented Jun 27, 2025

No description provided.

@JSMonk JSMonk requested a review from a team as a code owner June 27, 2025 15:44
@AlejandraPedroza AlejandraPedroza self-assigned this Jul 1, 2025
@AlejandraPedroza AlejandraPedroza changed the base branch from master to kotlin-js-doc-update July 10, 2025 14:40
@AlejandraPedroza AlejandraPedroza force-pushed the bring-back-more-information-to-js-overview branch from 6a3dc35 to f92471f Compare July 10, 2025 14:41
Copy link
Contributor

@AlejandraPedroza AlejandraPedroza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this content! I've reviewed it and made some adjustments in style and format. Can you please check the new version?

JSMonk and others added 2 commits August 21, 2025 11:58
@AlejandraPedroza AlejandraPedroza force-pushed the bring-back-more-information-to-js-overview branch from a220e0b to 325e476 Compare August 21, 2025 12:24
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update! 🚀 I left a couple of comments, please let me know what you think


Kotlin/JS provides the ability to transpile your Kotlin code, the Kotlin standard library, and any compatible dependencies
to JavaScript. The current implementation of Kotlin/JS targets [ES5](https://www.ecma-international.org/ecma-262/5.1/).
Kotlin/JavaScript (Kotlin/JS) lets you transpile your Kotlin code, the Kotlin standard library, and any compatible dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Kotlin/JavaScript (Kotlin/JS) lets you transpile your Kotlin code, the Kotlin standard library, and any compatible dependencies
Kotlin/JavaScript (Kotlin/JS) lets you compile your Kotlin code, the Kotlin standard library, and any compatible dependencies

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While transpile is a correct term; for some reason, we only use it for JS. Is there a reason for that? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check with SME if we want to refer to the same thing here to safely modify it.

Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates — I added a couple of additional suggestions, otherwise LGTM! 🚀

@AlejandraPedroza AlejandraPedroza merged commit e6cc0c4 into kotlin-js-doc-update Aug 27, 2025
@AlejandraPedroza AlejandraPedroza deleted the bring-back-more-information-to-js-overview branch August 27, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants