KTL-2944 Add webteam youtube-playlist #5017
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpachoo
commented
Aug 14, 2025
| @@ -5,7 +5,8 @@ import cn from 'classnames'; | |||
| import styles from './additional-materials.module.css'; | |||
| import { useTextStyles } from '@rescui/typography'; | |||
|
|
|||
| import YoutubePlayer from '@jetbrains/kotlin-web-site-ui/out/components/youtube-player'; | |||
| // @ts-ignore | |||
| import YoutubePlaylist from '@webteam/youtube-playlist/lib'; | |||
There was a problem hiding this comment.
I don't know why, but types resolve doesn't work with it.
nikpachoo
commented
Aug 14, 2025
Comment on lines
+66
to
+71
| if (useFallbackForInternalPackages) { | ||
| config.resolve.alias['@webteam'] = path.resolve( | ||
| __dirname, | ||
| 'components/webteam-fallback' | ||
| ); | ||
| } |
There was a problem hiding this comment.
this is the place, where all the magic happens.
We just resolve another module in case the env variable is set.
nikpachoo
commented
Aug 14, 2025
nikpachoo
commented
Aug 14, 2025
nikpachoo
force-pushed
the
ktl-2944-playlist
branch
from
7d83a28 to
0bcb6dd
Compare
nikpachoo
commented
Aug 14, 2025
Comment on lines
+1
to
+19
| import React, { FC } from 'react'; | ||
|
|
||
| import YoutubePlayer from '@jetbrains/kotlin-web-site-ui/out/components/youtube-player'; | ||
|
|
||
| interface YoutubePlaylistProps { | ||
| playlistId: string; | ||
| playlistTitle: string; | ||
| } | ||
|
|
||
| const YoutubePlaylist: FC<YoutubePlaylistProps> = ({ playlistId, playlistTitle }) => { | ||
| return ( | ||
| <YoutubePlayer | ||
| mode={1} | ||
| id={playlistId} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default YoutubePlaylist; |
There was a problem hiding this comment.
Fallback component.
Initially I wanted to use a very simple one, only with a text, but then decided to use the player.
Not sure that this is needed.
nikpachoo
force-pushed
the
ktl-2944-playlist
branch
3 times, most recently
from
ce4d1cd to
5a21005
Compare
nikpachoo
commented
Aug 15, 2025
Comment on lines
+18
to
+29
| transpiledPackages.push( | ||
| '@webteam/youtube-playlist', | ||
| '@webteam/ui-contexts', | ||
| '@webteam/colors', | ||
| '@webteam/toggle', | ||
| '@webteam/youtube-player', | ||
| '@webteam/use-fetch', | ||
| '@webteam/use-async-data', | ||
| '@webteam/bem-cn-fast', | ||
| '@webteam/list' | ||
| ) | ||
| } |
There was a problem hiding this comment.
This is not a workaround, it is expected to be here, we do the same with the RescUI components above.
nikpachoo
force-pushed
the
ktl-2944-playlist
branch
3 times, most recently
from
5605eb4 to
3e899b8
Compare
nikpachoo
force-pushed
the
ktl-2944-playlist
branch
from
3e899b8 to
1f926a0
Compare
krutilov
reviewed
Aug 18, 2025
| '@webteam/list' | ||
| ) | ||
| } | ||
|
|
||
| const withTranspile = nextTranspileModules(transpiledPackages); |
There was a problem hiding this comment.
We can probably keep it for now, but I found out that next-transpile-modules is deprecated see https://github.com/martpie/next-transpile-modules/releases/tag/the-end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTL-2944/Add-webteam-youtube-playlist
How does it work
By default WEBTEAM_UI_NPM_TOKEN is expected.
External users can set
export USE_FALLBACK_FOR_INTERNAL_PACKAGES=1to install dependencies and run the website locally.In this case, a fallback UI component will be used.
How we can use webteam-ui
No limits, we just need to to the following things:
transpiledPackagessection in the next.js config.