Fix methods for create_attribute()
in Twing, and tweak some tests accordingly
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
/lib/Attribute.js
so that thecreate_attribute()
function correctly returns an Attribute object with methods in Twing.It also:
'should return an Attribute object with methods'
test (for both Twig.js and Twing) to use.addClass(["class1", "class2"])
instead of.addClass("class1", "class2")
(according to the Drupal docs, an array should be used here for multiple classes);test.failing(...)
totest(...)
for the Twing'should return an Attribute object with methods'
test;'should export drupal-attribute as Attribute'
tests by changingtest(...)
totest.failing(...)
(perhaps it would be better to remove them altogether if this PR is accepted);test(...)
totest.failing(...)
for the Twing'should return an Attribute object with accessible properties'
test, which is now failing (as the Twig.js one already was).The last item (property-access now failing on Attribute objects in Twing) is clearly undesirable, and off-hand I'm not sure how to fix it, but in my experience the methods are far more commonly used than property access, so this strikes me as a good trade-off. Property-access can be tackled later separately.
Fixes #51