Skip to content

General overhaul #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 9, 2025
Merged

General overhaul #120

merged 32 commits into from
Apr 9, 2025

Conversation

BatyLeo
Copy link
Member

@BatyLeo BatyLeo commented Dec 23, 2024

  • Reorganize src files into losses and layers
  • Remove unnecessary trainings in tests
  • Use DifferentiableExpectations as a dependency
    • Rewrite perturbed using Reinforce
    • Remove probability distributions, and other things that are now in DifferentiableExpectations
    • Now, pushforward and perturbed rrules are located in DifferentiableExpectations
    • accordingly update losses relying on Perturbed
  • Rename GeneralizedMaximizer to LinearMaximizer
  • Use DocStringExtensions for docstrings
  • Remove ThreadsX as a dependency
  • Update DifferentiableFrankWolfe compat
  • Temporary fix for multi dimensional array to be compatible with newest version of ImplicitDifferentiation

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 85.91549% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/layers/perturbed/perturbed.jl 67.85% 9 Missing ⚠️
src/layers/perturbed/perturbation.jl 76.92% 6 Missing ⚠️
src/losses/fenchel_young_loss.jl 93.75% 3 Missing ⚠️
src/layers/regularized/regularized_frank_wolfe.jl 50.00% 1 Missing ⚠️
src/utils/utils.jl 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
ext/InferOptFrankWolfeExt.jl 100.00% <100.00%> (ø)
src/InferOpt.jl 100.00% <ø> (ø)
src/interface.jl 100.00% <100.00%> (ø)
src/layers/perturbed/utils.jl 100.00% <100.00%> (ø)
src/layers/regularized/soft_argmax.jl 100.00% <ø> (ø)
src/layers/regularized/soft_rank.jl 71.79% <ø> (ø)
src/layers/regularized/sparse_argmax.jl 100.00% <ø> (ø)
src/layers/simple/identity.jl 77.77% <ø> (ø)
src/layers/simple/interpolation.jl 80.00% <ø> (ø)
src/losses/imitation_loss.jl 86.36% <ø> (ø)
... and 11 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BatyLeo BatyLeo marked this pull request as ready for review December 25, 2024 16:37
@BatyLeo BatyLeo merged commit 4d8c3ff into main Apr 9, 2025
3 checks passed
@BatyLeo BatyLeo deleted the perturbed-overhaul branch April 9, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface with DifferentiableExpectations.jl Get rid of ThreadsX?
2 participants