Add successfull_step test to lyapunov calculation and warning in rescaling distance #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the discussion in 262 and 184 as
successful_step
was not implemented inlyapunov
function of DynamicalSystems.jl v3.I'm also proposing that rescaling errors should give warnings instead of errors, as this might break execution of longer codes. The test is nothing fancy, but it does the job for testing
NaN
's.In my local files this addition makes the
@testset "analytic IDT=$(IDT), IIP=$(IIP)"
to fail with an errorMethodError: no method matching isfinite(::SVector{2, Float64}) The function
isfiniteexists, but no method is defined for this combination of argument types.
in
dynamicalsystem_inferface.jl
file, I suspect this is some problem in my local instalations, but please double check.