Skip to content

Conversation

Jaderpolli
Copy link
Contributor

This is related to the discussion in 262 and 184 as successful_step was not implemented in lyapunov function of DynamicalSystems.jl v3.

I'm also proposing that rescaling errors should give warnings instead of errors, as this might break execution of longer codes. The test is nothing fancy, but it does the job for testing NaN's.

In my local files this addition makes the @testset "analytic IDT=$(IDT), IIP=$(IIP)" to fail with an error

MethodError: no method matching isfinite(::SVector{2, Float64}) The functionisfinite exists, but no method is defined for this combination of argument types.

in dynamicalsystem_inferface.jl file, I suspect this is some problem in my local instalations, but please double check.

@Datseris
Copy link
Member

thanks for the PR, I'll have a look at the error if this persists. Can you also update the documentation of the function about when it returns NaN?

@Datseris Datseris merged commit d4cc6cc into JuliaDynamics:main Aug 25, 2025
1 of 2 checks passed
@Datseris
Copy link
Member

thanks!

@Jaderpolli Jaderpolli deleted the reimplement-successful-step-test branch August 28, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants