-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add a warning against having multiple copies of a shared library loaded #43007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
petvana
wants to merge
18
commits into
JuliaLang:master
Choose a base branch
from
petvana:warn_dllist_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2194497
Reincarnate PR #7490 - Add warning when loading multiple copies
petvana 6ad3aaf
Update comments
petvana 4d6f578
Merge branch 'JuliaLang:master' into warn_dllist_v2
petvana e2d947f
Make warning opt-out and disable them when symlinked the the same file.
petvana 0e9915d
Update comments
petvana c543bda
Improve complexity to O(n^2 log n)
petvana e4642fe
Cache dlname() outputs
petvana 626b711
Make PR thread-safe
petvana a635c32
Fix comment
petvana 527211f
Do not move sysinfo.jl in Base.jl
petvana 72a312b
Use Dict instead of sortperm
petvana 9a694b8
Do not export check_dllist()
petvana 2b1a6c8
Rename fulpaths to paths
petvana aa25345
Add option to suppress warnings
petvana 46a9ba0
Add comments and note to docs
petvana 9b5cb23
Merge branch 'master' into warn_dllist_v2
petvana 468425c
Merge branch 'master' into warn_dllist_v2
petvana dadc8d3
Merge branch 'master' into warn_dllist_v2
petvana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not thread-safe and goes against #41602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment; it should be thread-safe now (without a performance regression).