Storybook upgrade to v9 #1436
Open
Storybook upgrade to v9 #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the storybook version to v9
Currently the dark mode functionality doesn't work as the plugin is not being actively maintained
There is currently a PR open: hipstersmoothie/storybook-dark-mode#298 however it seems like there will still be some time before using this.
There is a fork that is available and the team seems to be on board with maintaining the plugin: https://github.com/vuelessjs/storybook-dark-mode
If the preference is to maintain the current plugin then this PR will have to wait, otherwise I can switch to the forked plugin which has been updated to storybook 9
As a reference, I just ran a
npx storybook@latest upgradecommand to get the basics and then I needed to make some minor adjustments where necessary