Skip to content

Renovate Bot Integration in CI #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

thekester
Copy link

This is a follow-up to PR #581. I originally used branch 572-use-renovate-in-ci to add a Renovate configuration, but the rebase onto dev caused a messy commit history. To fix this, I created a new branch—572-use-renovate-in-ci-v2—directly from the latest dev and added a single commit with the .github/workflows/renovate.yml file. This new branch provides a clean, easy-to-review commit history, effectively replacing the old branch.

@popescu-v popescu-v self-requested a review March 24, 2025 13:06
@popescu-v popescu-v linked an issue Mar 24, 2025 that may be closed by this pull request
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commit hook checks fail (see https://github.com/KhiopsML/khiops/pull/647/checks#step:4:229).

To make sure the checks pass, one needs to:

  1. Create Python virtual environment (virtualenv -p path/to/bin/pythonx.y my_virtual_env)
  2. Activate the Python virtual environment (. my_virtual_env/bin/activate)
  3. Install pre-commit inside the Python virtual environment (pip install -U pre-commit)
  4. Run the yamlfix pre-commit hook before doing git add (pre-commit run yamlfix --file .github/workflows/renovate.yml)
    4'. Alternatively, if wishing to automate the run of the pre-commit hooks, one can also:
    • Install the pre-commit hooks (pre-commit install inside the khiops repo / directory)
    • then, each time git commit is attempted, the commit will fail if any pre-commit hook fails.

@thekester
Copy link
Author

Thanks, i just did the pre-commit run yamlfix --file .github/workflows/renovate.yml

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, LGTM.
However, before being able to merge, IMHO we would need to:

  • squash the 2 commits
  • Rephrase the commit message of the single remaining commit, to:
       Add renovate workflow
       closes #572
    

@thekester thekester force-pushed the 572-use-renovate-in-ci-v2 branch 2 times, most recently from 6996a53 to b1813bf Compare April 25, 2025 15:59
@thekester thekester force-pushed the 572-use-renovate-in-ci-v2 branch from b1813bf to 351e2da Compare April 25, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use renovate in our CI
2 participants