Skip to content

Fix Unit Test framework #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix Unit Test framework #670

wants to merge 1 commit into from

Conversation

bruno-at-orange
Copy link
Contributor

MPI Unit Tests were actually not launched with mpi. A (forgotten) cherry-pick from dev fixes it

@bruno-at-orange bruno-at-orange requested review from popescu-v and removed request for popescu-v April 3, 2025 13:43
@bruno-at-orange bruno-at-orange marked this pull request as draft April 3, 2025 13:52
MPI Unit Tests were actually not launched with mpi.
A cherry-pick from dev fixes it
@bruno-at-orange bruno-at-orange force-pushed the test-unit-tests branch 2 times, most recently from 3814cf8 to f0bbe50 Compare April 7, 2025 09:42
@bruno-at-orange bruno-at-orange marked this pull request as ready for review April 7, 2025 09:54
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, LGTM for the scope of the current PR.
However, before approving, I wonder whether we should test in the CI that MPI tests are launched with mpiexec and fail the pipeline otherwise (thusly capturing potential regressions on this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants