Skip to content

Handle background update in a right way and add an option to control it #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Krukov
Copy link
Owner

@Krukov Krukov commented Oct 1, 2024

fix for issue #265

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.81%. Comparing base (3ab8f37) to head (258a0c3).

Files with missing lines Patch % Lines
cashews/decorators/cache/hit.py 66.66% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   93.85%   93.81%   -0.04%     
==========================================
  Files          54       54              
  Lines        3564     3574      +10     
  Branches      620      622       +2     
==========================================
+ Hits         3345     3353       +8     
- Misses        109      110       +1     
- Partials      110      111       +1     
Flag Coverage Δ
unittests 93.70% <87.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krukov Krukov merged commit db7e951 into master Oct 1, 2024
6 checks passed
@Krukov Krukov deleted the call-early-hit-background branch November 30, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants