Skip to content

refactor: simplify canary status #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions config/crd/rollout/rollout.kusionstack.io_rolloutruns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4754,53 +4754,6 @@ spec:
state:
description: State is Rollout step state
type: string
targetStatuses:
description: TargetStatuses describes the referenced workloads status
items:
properties:
cluster:
description: Cluster defines which cluster the workload is in.
type: string
generation:
description: Generation is the found in workload metadata.
format: int64
type: integer
name:
description: Name is the workload name
type: string
observedGeneration:
description: ObservedGeneration is the most recent generation observed for this workload.
format: int64
type: integer
replicas:
description: Replicas is the desired number of pods targeted by workload
format: int32
type: integer
stableRevision:
description: StableRevision is the old stable revision used to generate pods.
type: string
updatedAvailableReplicas:
description: UpdatedAvailableReplicas is the number of service available pods targeted by workload that have the updated template spec.
format: int32
type: integer
updatedReadyReplicas:
description: UpdatedReadyReplicas is the number of ready pods targeted by workload that have the updated template spec.
format: int32
type: integer
updatedReplicas:
description: UpdatedReplicas is the number of pods targeted by workload that have the updated template spec.
format: int32
type: integer
updatedRevision:
description: UpdatedRevision is the updated template revision used to generate pods.
type: string
required:
- replicas
- updatedAvailableReplicas
- updatedReadyReplicas
- updatedReplicas
type: object
type: array
targets:
description: WorkloadDetails contains release details for each workload
items:
Expand Down
9 changes: 1 addition & 8 deletions rollout/v1alpha1/rolloutrun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ type RolloutRunStatus struct {
Error *CodeReasonMessage `json:"error,omitempty"`
// CanaryStatus describes the state of the active canary release
// +optional
CanaryStatus *RolloutRunCanaryStatus `json:"canaryStatus,omitempty"`
CanaryStatus *RolloutRunStepStatus `json:"canaryStatus,omitempty"`
// BatchStatus describes the state of the active batch release
// +optional
BatchStatus *RolloutRunBatchStatus `json:"batchStatus,omitempty"`
Expand All @@ -151,13 +151,6 @@ type RolloutRunStatus struct {
TargetStatuses []RolloutWorkloadStatus `json:"targetStatuses,omitempty"`
}

type RolloutRunCanaryStatus struct {
RolloutRunStepStatus `json:",inline"`
// TargetStatuses describes the referenced workloads status
// +optional
TargetStatuses []RolloutWorkloadStatus `json:"targetStatuses,omitempty"`
}

type RolloutRunBatchStatus struct {
// RolloutBatchStatus contains status of current batch
RolloutBatchStatus `json:",inline"`
Expand Down
24 changes: 1 addition & 23 deletions rollout/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading