Skip to content

fix: capture http server errors #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

Conversation

jemshad
Copy link
Contributor

@jemshad jemshad commented Jun 25, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1421

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Jun 25, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15874069214

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 46.343%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/server/options.go 0 2 0.0%
pkg/server/route/route.go 0 5 0.0%
Totals Coverage Status
Change from base Build 15823185054: -0.004%
Covered Lines: 11380
Relevant Lines: 24556

💛 - Coveralls

@ruquanzhao
Copy link
Collaborator

@jemshad Thank you for your contribution!🎉

By the way, the Kusion milestone ends on June 30th. If you feel it's ready, please remove the draft status from this PR.

@ruquanzhao
Copy link
Collaborator

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

One more thing, since this is your first code contribution, the CLA(Contributor License Agreement) need be signed.

Just follow the CLA Assistant Lite bot's instructions, and you'll be all set! Please feel free to ping me know if you need further help.

@ruquanzhao ruquanzhao self-requested a review June 27, 2025 02:59
@jemshad jemshad marked this pull request as ready for review July 7, 2025 16:57
@jemshad
Copy link
Contributor Author

jemshad commented Jul 7, 2025

I have read the CLA Document and I hereby sign the CLA

@jemshad
Copy link
Contributor Author

jemshad commented Jul 7, 2025

@jemshad Thank you for your contribution!🎉

By the way, the Kusion milestone ends on June 30th. If you feel it's ready, please remove the draft status from this PR.

My apologies. Got caught up in a few other things. I have removed the draft status.

@jemshad jemshad changed the title capture http server errors fix: capture http server errors Jul 7, 2025
@ruquanzhao
Copy link
Collaborator

@jemshad Thank you for your contribution!🎉
By the way, the Kusion milestone ends on June 30th. If you feel it's ready, please remove the draft status from this PR.

My apologies. Got caught up in a few other things. I have removed the draft status.

Hi, @jemshad , take it easy in open-source community and no need to apologize at all! 😊

Let's move on and get this merged.

Copy link
Collaborator

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruquanzhao ruquanzhao merged commit 5a1bffb into KusionStack:main Jul 8, 2025
7 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Kusion server should exit gracefully when the port is occupied
3 participants