Skip to content

[DO NOT MERGE]: experiments with jemalloc and rayon #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jun 12, 2025

Description

Scope: core / benches

Type of change: feat

Content description:

  • add parallel iterators over i-cells
  • add par-internals feature to core crate
    • use rayon's par_extend and collect from parallel iterators to see if we have some first touch effects
  • add jemalloc feature to benches
    • see if it affects parallel performance

Additional information

  • New dependency: tikv-jemallocator

Necessary follow-up

run benches with one and/or the other, along with variations on thread binding and hyperthreading.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.61345% with 79 lines in your changes missing coverage. Please review.

Project coverage is 86.82%. Comparing base (9b352cd) to head (9222a3d).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim3/basic_ops.rs 0.00% 52 Missing ⚠️
honeycomb-core/src/cmap/dim2/basic_ops.rs 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   87.41%   86.82%   -0.59%     
==========================================
  Files          72       72              
  Lines       11423    11514      +91     
==========================================
+ Hits         9985     9997      +12     
- Misses       1438     1517      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imrn99
Copy link
Collaborator Author

imrn99 commented Jun 12, 2025

the CI works again lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants