Skip to content

refactor!: rename transactional methods with _tx suffix #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2025

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jul 24, 2025

title

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 142 lines in your changes missing coverage. Please review.

Project coverage is 86.23%. Comparing base (ceb8d35) to head (ae0e6d5).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim3/sews/two.rs 67.03% 30 Missing ⚠️
honeycomb-kernels/src/remeshing/cut.rs 0.00% 21 Missing ⚠️
honeycomb-core/src/cmap/dim3/sews/three.rs 59.57% 19 Missing ⚠️
honeycomb-core/src/cmap/dim3/orbits.rs 25.00% 18 Missing ⚠️
honeycomb-core/src/cmap/dim3/basic_ops.rs 79.62% 11 Missing ⚠️
honeycomb-core/src/cmap/dim3/links/three.rs 63.63% 8 Missing ⚠️
honeycomb-kernels/src/triangulation/fan.rs 52.94% 8 Missing ⚠️
honeycomb-core/src/cmap/dim3/structure.rs 30.00% 7 Missing ⚠️
honeycomb-core/src/cmap/dim2/structure.rs 50.00% 5 Missing ⚠️
honeycomb-kernels/src/remeshing/swap.rs 60.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   86.01%   86.23%   +0.21%     
==========================================
  Files          73       73              
  Lines       10192    10068     -124     
==========================================
- Hits         8767     8682      -85     
+ Misses       1425     1386      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imrn99 imrn99 marked this pull request as ready for review July 24, 2025 16:11
@imrn99 imrn99 merged commit a9d382d into master Jul 24, 2025
17 checks passed
@imrn99 imrn99 deleted the rename-tx-methods branch July 24, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants