fix: test identify method #4920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable31 |
|
/backport to stable30 |
vitormattos
force-pushed
the
fix/test-identify-method
branch
3 times, most recently
from
e39a8ae to
67ca9c5
Compare
added 6 commits
May 8, 2025 14:11
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
At the first case, when is from identify methods, all is objects, when is from sign methods, are strings Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
fix/test-identify-method
branch
from
67ca9c5 to
9aa633b
Compare
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the reviewer:
I wrote the integration test and before the fix, the test was breaking. After applying the fix, the test passed.
Fix: #4882
And wasn't really related to French, only was a French user that identified the bug.