Skip to content

chore: scenary validate test #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

chore: scenary validate test #5198

wants to merge 21 commits into from

Conversation

Any97Cris
Copy link
Contributor

Pull Request Description

Related Issue

Issue Number: #1967

Pull Request Type

Chore

@Any97Cris Any97Cris self-assigned this Jul 4, 2025
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Jul 4, 2025
@vitormattos vitormattos changed the title chore: scenery validate test chore: scenary validate test Jul 7, 2025
@vitormattos vitormattos moved this from 0. Needs triage to 2. in progress in Roadmap Jul 9, 2025
@vitormattos vitormattos self-requested a review July 9, 2025 01:03
vitormattos
vitormattos requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be necessary to implement the code to cover those changes

@github-project-automation github-project-automation bot moved this from 2. in progress to 1. to do in Roadmap Jul 9, 2025
@vitormattos vitormattos moved this from 1. to do to 2. in progress in Roadmap Jul 9, 2025
@vitormattos vitormattos force-pushed the chore/correct-validate-field branch from 195b468 to abfb7e6 Compare July 22, 2025 20:17
vitormattos

This comment was marked as resolved.

Sign in to view

vitormattos
vitormattos reviewed Aug 18, 2025
View reviewed changes
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you need to recreate src/helpers/certification.js to send it to the front end. I think the best way is via an initial state, perhaps named certification_rules.

It might be a good idea to create a toArray method in the RulesServices class. This could be a good way to transform the PHP code into JavaScript Object Notation and send it serialized to the front end via the initial state.

And then, remove the src/helpers/certification.js matching the suggestion that was exposed at the issue:

To do this you will need to move the file apps-extra/libresign/src/helpers/certification.js to be a helper in API side and return this as JSON in an initial state to frontend.

@Any97Cris Any97Cris force-pushed the chore/correct-validate-field branch 2 times, most recently from 77b64e6 to 82548ab Compare August 21, 2025 20:11
vitormattos
vitormattos reviewed Aug 21, 2025
View reviewed changes
vitormattos
vitormattos reviewed Aug 21, 2025
View reviewed changes
tests/php/Unit/Service/Certificate/RulesServiceTest.php

public static function providerGetHelperTextWithInvalidFieldName(): array {
return [
['INVALID'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
['INVALID'],
[null],
['INVALID'],

tests/php/Unit/Service/Certificate/RulesServiceTest.php

public static function providerGetRuleToInvalidField(): array {
return [
['INVALID'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
['INVALID'],
[null],
['INVALID'],

Any97Cris and others added 14 commits August 25, 2025 15:07
@Any97Cris
chore: scenery validate test
606d44a 
Signed-off-by: Crisciany Souza <[email protected]>
@Any97Cris
chore: more steps about tests
c0f6116 
Signed-off-by: Crisciany Souza <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
fix: name of scenario
7a12ad8 
I changed because the previous scenaio name was a copy paste of first
scenario.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
fix: adjust table row size
e3ea124 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: replace Name by Common Name
4dc81ff 
The entire name of this field is Common Name and not only Name.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: restrict the return type to nullable and string only
2930700 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: cover with more tests
a2eb250 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: test get helper text with invalid field name
558f102 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: test get rule to valid field
dffd511 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: test get rule to invalid field
7521121 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
chore: add type hint to return
28c4a14 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
fix: consider to return empty array when is invalid field name
2ebc23f 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
fix: run cs:fix
82dd646 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos @Any97Cris
fix: run cs:fix
76d81a1 
Signed-off-by: Vitor Mattos <[email protected]>
@Any97Cris Any97Cris force-pushed the chore/correct-validate-field branch from 82548ab to 32e2dd5 Compare August 25, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos requested changes

Assignees

@Any97Cris Any97Cris

Labels
None yet
Projects
Roadmap
Status: 2. in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Any97Cris @vitormattos