Skip to content

fix/: change LTOA to LTO10 #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: v2.4.8-windows-support
Choose a base branch
from
Open

fix/: change LTOA to LTO10 #529

wants to merge 7 commits into from

Conversation

Magic-Kowel
Copy link

LTOA to LTO10

This pull request includes following changes or fixes.

  • Fix

Description

Change LTOA to LTO10

Type of change

  • Refactoring

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

vandelvan
vandelvan requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@vandelvan vandelvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Magic-Kowel
Did you test these changes? could you share the output of your tests please?
There was no need to change the variable and constant names but it's ok as long as you keep it consistent across all files.
Look into the comment I left please.
Thanks!

src/tape_drivers/hp_tape.c Outdated
@@ -346,7 +346,7 @@ static struct _timeout_tape timeout_lto9_hh[] = {
{-1, -1}
};

static struct _timeout_tape timeout_ltoA_hh[] = {
static struct _timeout_tape timeout_10_hh[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify lto not only 10

@Piloalucard
Copy link
Member

Hello @Magic-Kowel
Is there a specific reason to do this change? For what I can assume it seems to be a decision for maintain the decimal way to name the LTO10 generation instead of adopting the already merged hexadecimal way, but why? Is there any advantage?
Thank you in advance for the response!

retokromer
retokromer reviewed Jun 12, 2025
View reviewed changes
src/tape_drivers/tape_drivers.h Outdated
DRIVE_LTOA = 0x210A, /* Ultrium Gen A */
DRIVE_LTOA_HH = 0x220A, /* Ultrium Gen A Half-High */
DRIVE_LTO10 = 0x210A, /* Ultrium Gen A */
DRIVE_LTO10_HH = 0x220A, /* Ultrium Gen A Half-High */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gen 10 also in the comment?

retokromer
retokromer reviewed Jun 12, 2025
View reviewed changes
src/tape_drivers/tape_drivers.h Outdated
TC_MP_LTO8D_CART = 0x88, /* LTO8 Data cartridge */
TC_MP_LTO9D_CART = 0x98, /* LTO9 Data cartridge */
TC_MP_LTO10D_CART = 0xA8, /* LTOA Data cartridge */
TC_MP_LTOP10D_CART = 0xA9, /* LTOPA Data cartridge */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@Piloalucard Piloalucard mentioned this pull request Jul 3, 2025
Open
piste-jp
piste-jp requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make a few minor comments. It is really great if you accept the changes.

src/tape_drivers/hp_tape.c Outdated
@@ -87,7 +87,7 @@ struct _timeout_tape{
int timeout; /**< SCSI timeout */
};

/* Base timeout value for LTO */
/* Base timeout value for LTO */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove a space char. It looks inserted accidentally.

piste-jp
piste-jp approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retokromer retokromer retokromer left review comments

@vandelvan vandelvan vandelvan requested changes

@piste-jp piste-jp piste-jp approved these changes

@syaoraang syaoraang Awaiting requested review from syaoraang

@juliocelon juliocelon Awaiting requested review from juliocelon

Requested changes must be addressed to merge this pull request.

Assignees

@Magic-Kowel Magic-Kowel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Magic-Kowel @Piloalucard @retokromer @piste-jp @vandelvan