Skip to content

Add an alternative implementation for step3 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wang-Shengyuan
Copy link

This is a alternative implementation for stage 3 of clip_extracting. This script use FFmpeg rather than the original NVIDIA encoder implementation to solve initialization errors #5

@Lixsp11
Copy link
Owner

Lixsp11 commented Jul 19, 2025

Hi Shengyuan, sorry for the late reply, and thank you for your contribution.

I’ve reviewed and tested your implementation. Before we can merge it into the main branch, there are still a few issues that need to be addressed.

First, I’d like to clarify that the frame indices extracted in the first step are all calculated based on the target frame rate, which is 30 FPS, rather than the original frame rate of the video. This design choice ensures consistency and ease of use across the dataset. All extracted clips are standardized to the same video specifications: each clip is exactly 60 seconds long, has a frame rate of 30 FPS, and contains 1800 frames. Accordingly, the current version needs to be further adjusted to comply with this setup.

Second, we expect the alternative clips to follow the other specifications as the original ones. For instance, the video bitrate should be configured as VBR with a maximum of 4 Mbps, and the GOP length should be set to 240 frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants