Skip to content

fix(video): base min frame time strictly on client framerate #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 4, 2025

Description

This PR makes the minimum_frame_time calculation based strictly on the client requested framerate.

Client Framerate minimum_frame_time static FPS
30 33ms 23
60 16ms 33
90 11ms 55
120 8ms 64

TODO:

  • remove/update min_fps_factor from UI and config

Optionally:

  • allow multiplying the client requested framerate by up to 2

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.51%. Comparing base (808a862) to head (d30f9d4).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/video.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3844   +/-   ##
=======================================
  Coverage   11.51%   11.51%           
=======================================
  Files          92       92           
  Lines       17493    17493           
  Branches     8152     8152           
=======================================
  Hits         2015     2015           
  Misses      12981    12981           
  Partials     2497     2497           
Flag Coverage Δ
Linux 11.14% <0.00%> (ø)
Windows 13.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.cpp 21.44% <0.00%> (ø)

Copy link

codecov bot commented May 4, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the fix/video/base-min-frame-time-strictly-on-client-framerate branch from e851b28 to 1f1d027 Compare May 4, 2025 18:16
@ReenigneArcher ReenigneArcher force-pushed the fix/video/base-min-frame-time-strictly-on-client-framerate branch from 1f1d027 to d30f9d4 Compare May 4, 2025 18:35
Copy link

sonarqubecloud bot commented May 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frame rate drops when idle
1 participant