Settings > Application Settings > Replication tab enhancements #9388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsamaryv
changed the title
elsamaryv
force-pushed
the
settings-replication-form-enhancements
branch
from
56e0cc4 to
f026475
Compare
|
Checked commits elsamaryv/manageiq-ui-classic@f560dd6~...c4a2ca7 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint app/views/ops/_settings_replication_tab.html.haml
|
elsamaryv
force-pushed
the
settings-replication-form-enhancements
branch
from
c4a2ca7 to
10d350f
Compare
elsamaryv
force-pushed
the
settings-replication-form-enhancements
branch
from
10d350f to
84156ea
Compare
| }; | ||
|
|
||
| const validateSubscription = (selectedRow) => { | ||
| debugger |
There was a problem hiding this comment.
@elsamaryv can you please remove this line
Comment on lines
5
to
7
| :javascript | ||
| ManageIQ.angular.app.value('pglogicalReplicationFormId', 'new'); | ||
| miq_bootstrap('#form_div'); |
There was a problem hiding this comment.
I think we can remove these lines too since the form is now in React, are these needed for anything on the form?
| cy.login(); | ||
| cy.intercept('POST', '/ops/accordion_select?id=rbac_accord').as('accordion'); | ||
| cy.menu('Settings', 'Application Settings'); | ||
| cy.wait(1000); |
There was a problem hiding this comment.
Can we avoid these time based waits? Maybe using intercepts instead
|
Also, the cypress tests are consistently failing, we need to get them passing some what consistently or we can't merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts Settings > Replication tab to React. Also includes jest and cypress tests.
Before
Add subscription
Validation failure
After
Add subscription modal
Subscription table
Validation failure
Edit subscription
