fix: Remove aggregated balance popover and unused keys #32524

amandaye0h · 2025-05-05T18:30:02Z

Description

This PR removes the aggregated balance popover to reduce the visual noise on the page. It streamlines the IA on the page in the post-Onboarding state, enabling users to focus on their assets and the carousel component.

These changes are part of the overall UI update to the home page.

Related issues

Fixes:

Manual testing steps

After onboarding, popover should not appear
Keys for message.json files should be removed

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-05T18:30:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-05-05T19:25:57Z

Builds ready [c8b17d5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1234 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1234	1121	1537	68	1272	1366
			load	1071	974	1333	62	1110	1182
			domContentLoaded	1064	969	1326	62	1104	1176
			domInteractive	18	14	67	8	17	31
			firstPaint	633	102	1225	427	1060	1150
			backgroundConnect	7	4	39	5	7	22
			firstReactRender	20	16	46	5	21	28
			getState	14	5	35	8	21	29
			initialActions	0	0	1	0	0	0
			loadScripts	822	720	1080	60	855	922
			setupStore	8	5	16	2	8	13
	Webpack	Home	uiStartup	2168	1757	2539	163	2292	2403
			load	1683	1346	1985	126	1779	1855
			domContentLoaded	1676	1342	1960	126	1774	1847
			domInteractive	16	11	58	10	13	43
			firstPaint	169	63	365	60	191	326
			backgroundConnect	28	10	68	15	36	59
			firstReactRender	185	55	365	114	313	355
			getState	17	4	271	31	16	30
			initialActions	3	1	6	1	3	5
			loadScripts	1671	1341	1936	126	1771	1845
			setupStore	21	6	250	29	22	33
Firefox	Browserify	Home	uiStartup	1360	1170	1702	101	1411	1543
			load	1216	1024	1566	100	1277	1403
			domContentLoaded	1216	1024	1565	100	1277	1403
			domInteractive	107	38	265	37	116	178
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	230	24	20	31
			firstReactRender	24	19	67	8	23	42
			getState	7	4	30	3	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1196	1012	1542	100	1258	1386
			setupStore	8	4	207	20	6	9
	Webpack	Home	uiStartup	1537	1369	1986	127	1615	1810
			load	1321	1184	1758	110	1403	1503
			domContentLoaded	1321	1184	1757	110	1403	1503
			domInteractive	79	55	225	21	84	112
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	102	11	22	41
			firstReactRender	34	28	53	5	36	45
			getState	12	5	286	28	9	28
			initialActions	0	0	2	1	1	1
			loadScripts	1301	1166	1729	110	1381	1483
			setupStore	11	5	301	30	8	15

Benchmark value 1071 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1065 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1366 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Sum of mean exceeds: 5ms | Sum of p95 exceeds: 6ms
Sum of all benchmark exceeds: 11ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -1.44 KiB (-0.02%)
common: -289 Bytes (0%)

metamaskbot · 2025-05-05T20:13:44Z

Builds ready [0036810]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1205 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1205	1119	1523	59	1234	1312
			load	1041	908	1245	54	1072	1136
			domContentLoaded	1034	901	1241	55	1066	1131
			domInteractive	17	13	54	6	16	28
			firstPaint	723	171	1119	401	1053	1099
			backgroundConnect	8	4	39	6	7	23
			firstReactRender	19	14	42	4	20	27
			getState	15	5	45	8	20	30
			initialActions	0	0	1	0	0	0
			loadScripts	795	673	959	51	828	888
			setupStore	8	5	24	3	8	15
	Webpack	Home	uiStartup	2169	1680	2471	172	2304	2378
			load	1692	1339	2021	130	1779	1853
			domContentLoaded	1681	1272	2015	136	1773	1849
			domInteractive	16	11	69	11	13	47
			firstPaint	172	73	542	78	200	305
			backgroundConnect	30	10	452	44	33	53
			firstReactRender	189	53	376	108	299	364
			getState	13	4	57	10	16	32
			initialActions	3	1	7	1	4	5
			loadScripts	1673	1269	1991	135	1768	1827
			setupStore	17	6	47	8	22	33
Firefox	Browserify	Home	uiStartup	1382	1207	1758	112	1458	1603
			load	1235	1086	1597	108	1296	1473
			domContentLoaded	1235	1086	1596	108	1295	1473
			domInteractive	101	36	366	39	110	156
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	74	10	21	38
			firstReactRender	24	19	72	8	23	52
			getState	7	4	12	2	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1217	1069	1531	105	1279	1454
			setupStore	7	4	36	4	6	14
	Webpack	Home	uiStartup	1540	1376	2019	126	1591	1816
			load	1325	1178	1746	109	1359	1567
			domContentLoaded	1325	1178	1746	109	1359	1567
			domInteractive	80	36	303	28	84	124
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	47	6	25	40
			firstReactRender	35	29	65	6	37	48
			getState	10	5	33	7	9	30
			initialActions	1	0	5	1	1	1
			loadScripts	1305	1167	1724	109	1341	1550
			setupStore	9	5	68	8	8	22

Benchmark value 24 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Sum of mean exceeds: 0ms | Sum of p95 exceeds: 6ms
Sum of all benchmark exceeds: 6ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -1.44 KiB (-0.02%)
common: -499 Bytes (-0.01%)

metamaskbot · 2025-05-06T16:54:51Z

Builds ready [bb7ec15]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1110	1383	71	1288	1361
			load	1073	956	1232	69	1119	1197
			domContentLoaded	1066	940	1222	70	1115	1192
			domInteractive	18	13	63	9	16	30
			firstPaint	678	105	1231	431	1079	1184
			backgroundConnect	8	3	30	5	8	22
			firstReactRender	19	13	36	4	20	30
			getState	14	5	45	8	20	31
			initialActions	0	0	1	0	0	1
			loadScripts	829	708	976	68	879	948
			setupStore	7	5	13	1	7	10
	Webpack	Home	uiStartup	2157	1735	2503	177	2308	2372
			load	1669	1252	2018	142	1766	1857
			domContentLoaded	1662	1240	2014	141	1759	1853
			domInteractive	15	11	53	9	13	42
			firstPaint	162	67	494	63	185	288
			backgroundConnect	31	10	242	28	35	55
			firstReactRender	188	55	355	108	301	348
			getState	13	4	64	9	14	34
			initialActions	6	1	347	34	4	5
			loadScripts	1657	1238	2011	142	1756	1848
			setupStore	18	7	43	8	24	31
Firefox	Browserify	Home	uiStartup	1390	1203	1679	108	1455	1639
			load	1237	1050	1527	105	1290	1491
			domContentLoaded	1237	1049	1527	105	1289	1491
			domInteractive	104	37	363	40	118	173
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	77	8	23	34
			firstReactRender	23	20	52	6	23	30
			getState	8	4	38	4	8	18
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1035	1512	105	1266	1471
			setupStore	10	4	257	26	6	26
	Webpack	Home	uiStartup	1503	1357	2009	120	1533	1779
			load	1290	1162	1700	109	1308	1514
			domContentLoaded	1290	1162	1700	109	1308	1513
			domInteractive	77	45	150	18	84	125
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	47	7	23	41
			firstReactRender	35	27	51	5	37	45
			getState	10	4	34	7	9	31
			initialActions	0	0	1	0	1	1
			loadScripts	1270	1143	1672	109	1290	1489
			setupStore	8	5	40	5	8	20

Benchmark value 1073 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1066 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1198 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 949 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Sum of mean exceeds: 9ms | Sum of p95 exceeds: 38ms
Sum of all benchmark exceeds: 47ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -6.35 KiB (-0.12%)
ui: 11.18 KiB (0.16%)
common: -12.38 KiB (-0.13%)

metamaskbot · 2025-05-06T17:31:10Z

Builds ready [ee58397]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1198 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1198	1088	1507	63	1233	1290
			load	1041	906	1275	60	1080	1141
			domContentLoaded	1035	902	1268	59	1074	1136
			domInteractive	18	13	63	10	16	48
			firstPaint	738	78	1280	406	1053	1119
			backgroundConnect	7	4	35	3	7	10
			firstReactRender	24	16	82	11	27	51
			getState	15	5	41	9	20	32
			initialActions	0	0	1	0	0	1
			loadScripts	794	669	988	57	829	901
			setupStore	9	5	35	4	9	17
	Webpack	Home	uiStartup	2147	1767	2421	156	2285	2366
			load	1671	1250	1932	138	1770	1876
			domContentLoaded	1665	1245	1925	138	1765	1873
			domInteractive	15	11	58	9	13	41
			firstPaint	178	66	586	77	226	315
			backgroundConnect	38	9	460	63	32	91
			firstReactRender	171	54	366	115	294	354
			getState	20	4	318	47	14	40
			initialActions	3	1	6	1	3	5
			loadScripts	1660	1243	1922	140	1763	1871
			setupStore	16	6	38	8	20	33
Firefox	Browserify	Home	uiStartup	1376	1214	1839	123	1444	1649
			load	1224	1073	1624	109	1291	1439
			domContentLoaded	1224	1072	1624	110	1291	1439
			domInteractive	101	37	260	32	117	157
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	225	23	21	34
			firstReactRender	24	20	56	7	23	48
			getState	8	4	45	7	8	25
			initialActions	0	0	5	1	0	1
			loadScripts	1204	1055	1514	103	1276	1408
			setupStore	10	4	235	30	6	12
	Webpack	Home	uiStartup	1553	1383	1968	142	1609	1890
			load	1332	1196	1697	123	1397	1612
			domContentLoaded	1332	1196	1696	123	1397	1612
			domInteractive	78	34	167	21	86	122
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	45	5	23	35
			firstReactRender	37	29	49	5	40	45
			getState	11	5	34	8	10	32
			initialActions	1	0	2	1	1	1
			loadScripts	1313	1179	1679	123	1376	1600
			setupStore	8	5	43	5	8	14

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 49 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 51 exceeds gate value 45 for chrome browserify home p95 firstReactRender
Benchmark value 92 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 17ms
Sum of all benchmark exceeds: 21ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -6.85 KiB (-0.13%)
ui: 55.98 KiB (0.8%)
common: -6.43 KiB (-0.07%)

metamaskbot · 2025-05-06T20:42:08Z

Builds ready [acb7f4c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1204 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1204	1086	1329	56	1252	1307
			load	1046	949	1145	53	1083	1136
			domContentLoaded	1041	944	1141	53	1078	1129
			domInteractive	17	13	67	8	16	29
			firstPaint	780	96	1160	397	1071	1138
			backgroundConnect	7	4	17	2	7	9
			firstReactRender	20	14	79	8	19	31
			getState	14	6	30	7	19	26
			initialActions	0	0	1	0	0	0
			loadScripts	801	701	902	51	844	887
			setupStore	8	5	25	3	8	15
	Webpack	Home	uiStartup	2183	1637	2543	180	2327	2423
			load	1683	1249	2040	147	1782	1872
			domContentLoaded	1677	1245	2029	146	1778	1868
			domInteractive	16	11	68	11	13	47
			firstPaint	173	63	493	72	204	321
			backgroundConnect	34	9	333	39	38	63
			firstReactRender	189	55	368	109	307	339
			getState	13	4	36	7	16	27
			initialActions	3	1	6	1	4	5
			loadScripts	1672	1241	2006	145	1775	1867
			setupStore	23	7	325	38	23	33
Firefox	Browserify	Home	uiStartup	1379	1184	1694	108	1437	1613
			load	1235	1064	1548	110	1305	1477
			domContentLoaded	1235	1064	1548	110	1305	1477
			domInteractive	107	39	210	31	122	173
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	123	13	21	45
			firstReactRender	24	20	56	7	23	49
			getState	7	5	35	3	8	11
			initialActions	0	0	1	0	0	1
			loadScripts	1217	1051	1519	109	1289	1463
			setupStore	6	4	12	1	6	10
	Webpack	Home	uiStartup	1514	1365	2149	132	1560	1811
			load	1289	1175	1680	99	1328	1490
			domContentLoaded	1289	1175	1680	99	1328	1490
			domInteractive	79	54	159	18	84	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	102	10	24	40
			firstReactRender	36	29	52	5	39	47
			getState	14	5	297	29	10	32
			initialActions	0	0	2	1	1	1
			loadScripts	1269	1159	1661	99	1309	1475
			setupStore	16	5	301	47	8	41

Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 41 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 13ms
Sum of all benchmark exceeds: 17ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -1.59 KiB (-0.02%)
common: -499 Bytes (-0.01%)

metamaskbot · 2025-05-07T19:30:17Z

Builds ready [3191b02]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1227 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1227	1097	1422	68	1267	1356
			load	1068	956	1230	59	1111	1180
			domContentLoaded	1061	948	1224	60	1102	1174
			domInteractive	16	13	32	3	16	25
			firstPaint	717	85	1231	428	1085	1169
			backgroundConnect	8	4	47	6	8	23
			firstReactRender	22	15	53	8	21	45
			getState	15	6	108	13	19	37
			initialActions	0	0	1	0	0	1
			loadScripts	820	714	975	56	853	927
			setupStore	8	5	17	2	9	14
	Webpack	Home	uiStartup	2230	1842	2506	163	2350	2446
			load	1736	1388	2082	136	1817	1950
			domContentLoaded	1730	1382	2077	136	1808	1944
			domInteractive	16	12	62	10	13	44
			firstPaint	162	61	338	59	182	286
			backgroundConnect	33	10	283	30	41	64
			firstReactRender	189	56	364	112	299	342
			getState	20	4	283	39	17	36
			initialActions	6	1	252	25	4	6
			loadScripts	1725	1380	2075	137	1805	1943
			setupStore	24	6	264	34	22	44
Firefox	Browserify	Home	uiStartup	1358	1175	1843	122	1405	1628
			load	1214	1049	1707	122	1267	1500
			domContentLoaded	1214	1049	1706	122	1266	1499
			domInteractive	108	38	275	37	124	188
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	210	20	20	40
			firstReactRender	24	19	57	7	23	49
			getState	7	4	27	3	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1196	1036	1676	121	1248	1484
			setupStore	6	4	34	5	6	9
	Webpack	Home	uiStartup	1528	1359	1935	128	1579	1819
			load	1306	1170	1712	109	1349	1528
			domContentLoaded	1306	1170	1712	109	1349	1528
			domInteractive	76	34	145	16	83	102
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	78	11	23	50
			firstReactRender	35	29	47	4	37	44
			getState	10	5	32	6	10	29
			initialActions	0	0	2	1	1	1
			loadScripts	1286	1151	1691	108	1325	1513
			setupStore	11	5	293	29	9	20

cc: @HowardBraham
Benchmark value 1062 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 37 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 2231 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1737 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1730 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1725 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 1500 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1499 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1484 exceeds gate value 1475 for firefox browserify home p95 loadScripts
Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Sum of mean exceeds: 119ms | Sum of p95 exceeds: 28ms
Sum of all benchmark exceeds: 147ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -1.59 KiB (-0.02%)
common: -499 Bytes (-0.01%)

metamaskbot · 2025-05-08T01:16:25Z

Builds ready [9a19fa7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1202 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1202	1101	1458	57	1247	1279
			load	1051	948	1331	55	1093	1129
			domContentLoaded	1045	944	1325	55	1088	1124
			domInteractive	16	13	36	4	16	24
			firstPaint	791	138	1137	395	1068	1119
			backgroundConnect	8	4	37	5	7	22
			firstReactRender	19	15	35	4	20	30
			getState	16	6	73	10	21	32
			initialActions	0	0	3	0	0	1
			loadScripts	805	715	1056	53	844	881
			setupStore	8	5	14	2	8	12
	Webpack	Home	uiStartup	2165	1772	2554	144	2271	2367
			load	1671	1384	2014	111	1740	1839
			domContentLoaded	1665	1381	1986	110	1735	1835
			domInteractive	16	11	92	13	13	50
			firstPaint	169	67	406	68	190	299
			backgroundConnect	27	10	63	11	34	47
			firstReactRender	184	54	413	113	298	358
			getState	18	4	308	36	18	32
			initialActions	3	1	6	1	3	5
			loadScripts	1660	1379	1964	111	1731	1831
			setupStore	19	6	258	25	21	33
Firefox	Browserify	Home	uiStartup	1399	1215	1747	111	1450	1661
			load	1249	1069	1618	107	1304	1497
			domContentLoaded	1248	1069	1618	107	1304	1496
			domInteractive	105	40	323	34	117	151
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	69	8	22	39
			firstReactRender	24	20	59	6	24	30
			getState	10	4	179	18	9	14
			initialActions	0	0	2	0	0	1
			loadScripts	1230	1055	1604	106	1283	1475
			setupStore	6	4	36	3	6	10
	Webpack	Home	uiStartup	1562	1362	2182	167	1599	1975
			load	1337	1173	1792	142	1388	1686
			domContentLoaded	1337	1172	1791	142	1388	1686
			domInteractive	81	34	144	19	92	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	14	299	29	23	41
			firstReactRender	36	30	62	6	39	47
			getState	14	4	326	32	9	32
			initialActions	1	0	2	1	1	1
			loadScripts	1316	1156	1762	136	1371	1652
			setupStore	9	5	57	7	8	27

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 1249 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1249 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 1231 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 1661 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 1497 exceeds gate value 1495 for firefox browserify home p95 load
Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded
Benchmark value 1975 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1686 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1686 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1652 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 16ms | Sum of p95 exceeds: 122ms
Sum of all benchmark exceeds: 138ms

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -1.59 KiB (-0.02%)
common: -499 Bytes (-0.01%)

metamaskbot added the team-assets label May 5, 2025

amandaye0h changed the title ~~fix: Remove aggregated popover and unused keys~~ fix: Remove aggregated balance popover and unused keys May 6, 2025

amandaye0h and others added 7 commits May 8, 2025 02:51

Remove popover and unused keys

e5b4dd6

Remove unused imports and declarations

c48f62d

Remove unused functions and imports

51bfc88

FIx linting issues

c1058ea

Remove unused hooks

0ebed5f

Resolve declaration issues

b0dea93

Resolve conflicts with main

3191b02

amandaye0h force-pushed the agg-balance-popover-removal branch from 872f80a to 3191b02 Compare May 7, 2025 18:55

amandaye0h added 2 commits May 8, 2025 06:07

Merge branch 'main' into agg-balance-popover-removal

0cb20c6

Merge branch 'main' into agg-balance-popover-removal

9a19fa7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove aggregated balance popover and unused keys #32524

fix: Remove aggregated balance popover and unused keys #32524

amandaye0h commented May 5, 2025 •

edited

Loading

github-actions bot commented May 5, 2025

metamaskbot commented May 5, 2025

metamaskbot commented May 5, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 7, 2025

metamaskbot commented May 8, 2025

fix: Remove aggregated balance popover and unused keys #32524

Are you sure you want to change the base?

fix: Remove aggregated balance popover and unused keys #32524

Conversation

amandaye0h commented May 5, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented May 5, 2025

metamaskbot commented May 5, 2025

metamaskbot commented May 5, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 6, 2025

metamaskbot commented May 7, 2025

metamaskbot commented May 8, 2025

amandaye0h commented May 5, 2025 •

edited

Loading