Skip to content

cherry-pick fix: cp-12.18.0 smart account splash 3rd title copy #32528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented May 5, 2025

Description

The originally copy was accidentally removed in https://github.com/MetaMask/metamask-extension/pull/31774/files. This restores the copy and replaces the duplicated title

Open in GitHub Codespaces

Related issues

Fixes: #32523

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Image

After

CleanShot 2025-05-05 at 13 55 01

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner May 5, 2025 20:48
Copy link
Contributor

github-actions bot commented May 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 5, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • ui/pages/confirmations/components/confirm/splash/smart-account-update/smart-account-update.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [85646e6]
UI Startup Metrics (1258 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1258113715337512991389
load109397513526911321206
domContentLoaded108696613467011251201
domInteractive191367101744
firstPaint818103126441111191209
backgroundConnect84284822
firstReactRender21156572132
getState1454082029
initialActions001001
loadScripts845735108066886954
setupStore85293813
WebpackHomeuiStartup21841760259617322992505
load17061390207613417701994
domContentLoaded16971383206513017651957
domInteractive161164111346
firstPaint1696855867191299
backgroundConnect339243343572
firstReactRender19054357117306351
getState144260261433
initialActions317135
loadScripts16921381204112817641929
setupStore236299422040
FirefoxBrowserifyHomeuiStartup13701191168410814231575
load12241066153010712871432
domContentLoaded12241065153010712871431
domInteractive1013918929114151
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113163152134
firstReactRender23196352331
getState74374811
initialActions002001
loadScripts12061049150410512711416
setupStore74397625
WebpackHomeuiStartup15001350181210915761731
load1284116415438913381475
domContentLoaded1284116415438913381475
domInteractive76561431681116
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23155372444
firstReactRender35295053843
getState104538931
initialActions002111
loadScripts1264114915268813191455
setupStore12530130824
cc: @HowardBraham
Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1087 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 819 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 846 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2505 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Sum of mean exceeds: 109ms | Sum of p95 exceeds: 163ms
Sum of all benchmark exceeds: 272ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 3 Bytes (0%)
  • common: 68 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [4cf8cad]
UI Startup Metrics (1184 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1184108813915212171269
load102590711725610661131
domContentLoaded101990211665710601127
domInteractive181364101657
firstPaint69479114740810441107
backgroundConnect74263710
firstReactRender21155982141
getState1354981627
initialActions001001
loadScripts78666492556821895
setupStore85223815
WebpackHomeuiStartup22511869276318423852525
load17491436228016918461983
domContentLoaded17421432227616818401970
domInteractive171256101448
firstPaint1777353577194315
backgroundConnect44112965548238
firstReactRender17456405109297340
getState254329512148
initialActions328135
loadScripts17341430227516318381963
setupStore3172844528183
FirefoxBrowserifyHomeuiStartup13331154167110614051547
load11931006154410912591427
domContentLoaded11931006154310912591427
domInteractive1033727836112176
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18138181927
firstReactRender22195142227
getState7437479
initialActions001000
loadScripts1176991152810812431409
setupStore6434467
WebpackHomeuiStartup15381363200313716061802
load13201166169611514051512
domContentLoaded13201166169611514051512
domInteractive78361722183132
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect21165572241
firstReactRender35285053747
getState12427727928
initialActions001011
loadScripts13011147167711413901494
setupStore12521022832
cc: @HowardBraham
Benchmark value 57 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 2251 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1750 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1742 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 45 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 1734 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2525 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 239 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 183 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 176ms | Sum of p95 exceeds: 358ms
Sum of all benchmark exceeds: 534ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 3 Bytes (0%)
  • common: 68 Bytes (0%)

@digiwand digiwand added this pull request to the merge queue May 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2025
@digiwand digiwand added this pull request to the merge queue May 6, 2025
@HowardBraham HowardBraham removed this pull request from the merge queue due to a manual request May 6, 2025
@HowardBraham HowardBraham added this pull request to the merge queue May 6, 2025
@digiwand digiwand changed the title fix: smart account splash 3rd title copy cherry-pick:fix: smart account splash 3rd title copy May 6, 2025
@digiwand digiwand changed the title cherry-pick:fix: smart account splash 3rd title copy cherry-pick fix: smart account splash 3rd title copy May 6, 2025
Merged via the queue into main with commit a216d33 May 6, 2025
167 checks passed
@HowardBraham HowardBraham deleted the fix-smart-account-splash-copy branch May 6, 2025 18:33
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
@digiwand digiwand changed the title cherry-pick fix: smart account splash 3rd title copy cherry-pick fix: cp-12.18.0 smart account splash 3rd title copy May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong copy in the smart account splash screen
5 participants