-
Notifications
You must be signed in to change notification settings - Fork 5.2k
cherry-pick fix: cp-12.18.0 smart account splash 3rd title copy #32528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
|
Builds ready [85646e6]
UI Startup Metrics (1258 ± 75 ms)
Benchmark value 1259 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1087 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 819 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 846 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1389 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1206 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1201 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 955 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2505 exceeds gate value 2454 for chrome webpack home p95 uiStartup Sum of mean exceeds: 109ms | Sum of p95 exceeds: 163ms Sum of all benchmark exceeds: 272ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4cf8cad]
UI Startup Metrics (1184 ± 52 ms)
Benchmark value 57 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 2251 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1750 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1742 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 45 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1734 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2525 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 239 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 183 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 176ms | Sum of p95 exceeds: 358ms Sum of all benchmark exceeds: 534ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
May 6, 2025
vinistevam
approved these changes
May 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The originally copy was accidentally removed in https://github.com/MetaMask/metamask-extension/pull/31774/files. This restores the copy and replaces the duplicated title
Related issues
Fixes: #32523
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist