fix: cp-12.18.0 Infinite loader on approve request
#32548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
|
vinistevam
previously approved these changes
May 6, 2025
Builds ready [cc99a7f]
UI Startup Metrics (1207 ± 66 ms)
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 2228 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1743 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1736 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 42 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1731 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2147 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2144 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 234 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 2142 exceeds gate value 1970 for chrome webpack home p95 loadScripts Sum of mean exceeds: 134ms | Sum of p95 exceeds: 576ms Sum of all benchmark exceeds: 710ms Bundle size diffs
|
jpuri
previously approved these changes
May 6, 2025
Builds ready [cc99a7f]
UI Startup Metrics (1238 ± 78 ms)
Benchmark value 1239 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1081 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 836 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1387 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1217 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1212 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1210 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 969 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1712 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1707 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2460 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2049 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2008 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 1985 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1530 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1530 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1517 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 1648 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1411 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 1390 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1981 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1694 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1694 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1678 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 198ms | Sum of p95 exceeds: 462ms Sum of all benchmark exceeds: 660ms Bundle size diffs
|
Welbert5753
approved these changes
May 6, 2025
Builds ready [65107b1]
UI Startup Metrics (1214 ± 62 ms)
Benchmark value 1500 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 1485 exceeds gate value 1475 for firefox browserify home p95 loadScripts Sum of mean exceeds: 0ms | Sum of p95 exceeds: 21ms Sum of all benchmark exceeds: 21ms Bundle size diffs
|
jpuri
approved these changes
May 6, 2025
Builds ready [369d97e]
UI Startup Metrics (1207 ± 76 ms)
Benchmark value 48 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 1496 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1478 exceeds gate value 1475 for firefox browserify home p95 loadScripts Sum of mean exceeds: 0ms | Sum of p95 exceeds: 8ms Sum of all benchmark exceeds: 8ms Bundle size diffs
|
vinistevam
approved these changes
May 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
runway-github bot
added a commit
that referenced
this pull request
May 7, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix infinite loader on `approve` request described here: #32489 (comment) [](https://codespaces.new/MetaMask/metamask-extension/pull/32548?quickstart=1) ## **Related issues** Fixes: #32489 ## **Manual testing steps** 1. Connect to a dapp 2. Switch to Base 3. Select WETH 4. Trigger Approval ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/9ac4185c-f921-4178-ae51-2edb608578e2 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/32548?quickstart=1){kind=link}
runway-github bot
added a commit
that referenced
this pull request
May 7, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix infinite loader on `approve` request described here: #32489 (comment) [](https://codespaces.new/MetaMask/metamask-extension/pull/32548?quickstart=1) ## **Related issues** Fixes: #32489 ## **Manual testing steps** 1. Connect to a dapp 2. Switch to Base 3. Select WETH 4. Trigger Approval ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/9ac4185c-f921-4178-ae51-2edb608578e2 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this pull request
May 7, 2025
…e` request (#32548) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix infinite loader on `approve` request described here: #32489 (comment) [](https://codespaces.new/MetaMask/metamask-extension/pull/32548?quickstart=1) ## **Related issues** Fixes: #32489 ## **Manual testing steps** 1. Connect to a dapp 2. Switch to Base 3. Select WETH 4. Trigger Approval ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/9ac4185c-f921-4178-ae51-2edb608578e2 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
OGPoyraz
added a commit
that referenced
this pull request
May 7, 2025
…e` request (#32591) - fix: cp-12.18.0 Infinite loader on `approve` request (#32548) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to fix infinite loader on `approve` request described here: #32489 (comment) [](https://codespaces.new/MetaMask/metamask-extension/pull/32548?quickstart=1) ## **Related issues** Fixes: #32489 ## **Manual testing steps** 1. Connect to a dapp 2. Switch to Base 3. Select WETH 4. Trigger Approval ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/9ac4185c-f921-4178-ae51-2edb608578e2 ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [42fd53b](42fd53b) Co-authored-by: OGPoyraz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix infinite loader on
approverequest described here: #32489 (comment)Related issues
Fixes: #32489
Manual testing steps
Screenshots/Recordings
Before
After
WETH.on.Base.mov
Pre-merge author checklist
Pre-merge reviewer checklist