Allow the 3d swapper to create tetrahedra with 4 boundary vertices when not in FEM mode #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MMG5_chkswpgen() does not allow the creation of tetrahedra with 4 boundary vertices. I think this restriction should only be made in FEM mode, just like the restriction on creating edges between boundary points is only made in FEM mode (further up in the same function) and anatet4() is only called in FEM mode.
I made this modification because we need it for the meshes we create for the MICROCARD project. These meshes have lots of internal boundaries, often with only one layer of tetrahedra between them, and we don't want to have more layers because the space is very thin. Thus it is perfectly normal to have tetrahedra with all of their vertices on either of two boundaries. The refusal of these swaps costs me a factor 5 in quality for the worst 10% of tetrahedra.
I wrote the change such that it makes minimal changes to the blame.