Use Reflections library rather than Jar class scanning #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Reflections library rather than Jar class scanning.
Not all projects that implement the skript-parser will use Jars.
Using Reflections library also allows developers to define custom url types before skript-parser scans, such as NeoForge using Union URL Type. I need to register Union URL Type to Reflections before skript-parser.
For example Scroll https://github.com/ScrollLang on NeoForge and Fabric have development options to load the build/ classes for injection hotswapping. This allows avoiding the need to restart the Minecraft client for non new method changes.
So skript-parser will throw an exception as there is no source Jar (it's excluded as a library jar in NeoForge);
/addon/
scanning in the init method.