Always show the New Attribute button in EMLAttributesView #2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The button is now a UI element only and is never removed. It is no longer connected to a new blank model in the collection, which was leading to unexpected behaviour. The button is now always visible, stickign to the bottom of the list container when there are many attributes. Fixes #799, #1722, #1216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button is now a UI element only and is never removed from the view. It is no longer connected to a new blank model in the collection, which was leading to unexpected behaviour.
Our previous pattern of using a blank model to represent the "add new attribute" button was a little too complex and was leading to unexpected behaviours, like the button not showing up in some cases when the associated model was removed.
The button is now always visible, sticking to the bottom of the list container when there are many attributes.
Fixes #799 and #1722