-
Notifications
You must be signed in to change notification settings - Fork 68
Add fraction_field_type
and define fraction_field
method for fields
#2092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2092 +/- ##
==========================================
- Coverage 88.34% 88.33% -0.01%
==========================================
Files 126 126
Lines 31674 31679 +5
==========================================
+ Hits 27982 27984 +2
- Misses 3692 3695 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Can we then please also have some programmatic way for deciding the type of the fraction field of some ring, i.e. |
fraction_field
for fields
I agree with the idea of adding function fraction_field(a::RationalFunctionField{T, U}) where {T <: FieldElement, U <: Union{PolyRingElem, MPolyRingElem}}
return a.fraction_field::Union{FracField{U}}
end And this is also documented, so we can't simply change it. But I think that kind of throws a wrench into the idea behind this PR sigh; at the very least it would require a breaking release which renames the above |
4c14082
to
13c9d7b
Compare
fraction_field
for fieldsfraction_field_type
and define fraction_field
method for fields
13c9d7b
to
97e4466
Compare
97e4466
to
11dd456
Compare
@doc raw""" | ||
fraction_field_type(a) | ||
|
||
Return the type of the base ring of the given element, element type, parent or parent type $a$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return the type of the base ring of the given element, element type, parent or parent type $a$. | |
Return the type of the fraction field of the given element, element type, parent or parent type $a$. |
Seems natural and I see no harm in it?