Skip to content

Add has_preimage_with_preimage for FPModuleHomomorphism #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jamesnohilly
Copy link
Contributor

This PR adds has_preimage_with_preimage for FPModuleHomomorphism, as required to fix oscar-system/Oscar.jl#4977.

This partially changes functionality of preimage as now it errors when no preimage exists, previously this was not the case.

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (43ec804) to head (b2c1b62).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/ModuleHomomorphism.jl 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   88.33%   88.00%   -0.33%     
==========================================
  Files         126      126              
  Lines       31684    31663      -21     
==========================================
- Hits        27987    27864     -123     
- Misses       3697     3799     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element test for modules
2 participants