-
Notifications
You must be signed in to change notification settings - Fork 68
Document ideal interface #2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Document ideal interface #2113
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2113 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 126 126
Lines 31674 31674
=======================================
Hits 27982 27982
Misses 3692 3692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I am not too happy with the change. The function should not call In general, we are not really advertising |
Ok, if the previous code was as desired, then I'll remove the edit. I was a bit confused as it didn't work in AA, but I suppose it makes sense for its use beyond. |
Add a documentation page for the ideal interface.
This is addressing #1733 and comments in #2108. I plan to extend this slightly later
@fingolfin