Skip to content

Document ideal interface #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

emikelsons
Copy link
Contributor

@emikelsons emikelsons commented Jun 27, 2025

Add a documentation page for the ideal interface.

This is addressing #1733 and comments in #2108. I plan to extend this slightly later
@fingolfin

@emikelsons emikelsons reopened this Jun 27, 2025
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (8ea17bc) to head (b9b49ae).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2113   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files         126      126           
  Lines       31674    31674           
=======================================
  Hits        27982    27982           
  Misses       3692     3692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma
Copy link
Member

thofma commented Jun 27, 2025

I am not too happy with the change. The function should not call Generic.Ideal, but whatever ideal wants to spit out.

In general, we are not really advertising Generic.Ideal. It was kind of an experiment, but whether to keep it or not is not clear. See #2108 (comment).

@emikelsons
Copy link
Contributor Author

I am not too happy with the change. The function should not call Generic.Ideal, but whatever ideal wants to spit out.

In general, we are not really advertising Generic.Ideal. It was kind of an experiment, but whether to keep it or not is not clear. See #2108 (comment).

Ok, if the previous code was as desired, then I'll remove the edit. I was a bit confused as it didn't work in AA, but I suppose it makes sense for its use beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants