Skip to content

fix(backdropFilter): 添加小程序行内样式对 backdropFilter 样式属性的支持 #17553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

HyaCiovo
Copy link
Contributor

@HyaCiovo HyaCiovo commented Apr 17, 2025

这个 PR 做了什么? (简要描述所做更改)

毛玻璃效果现在挺常用的,建议添加对该属性的支持

  • 在 styleProperties 数组中添加了 'backdropFilter' 属性
  • 这个修改增加了小程序行内样式对 backdrop-filter CSS 属性的支持

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix 内联样式中使用 backdropFilter 会丢失 #17464
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Summary by CodeRabbit

  • 新功能
    • 新增对 CSS 属性 backdropFilter 的支持。

Copy link

coderabbitai bot commented Apr 17, 2025

"""

Walkthrough

本次变更在 styleProperties 数组中新增了 'backdropFilter' 属性。该数组用于枚举模块内支持的 CSS 样式属性。此次修改仅涉及属性名的补充,未影响其他逻辑、控制流或错误处理。

Changes

文件/路径 变更摘要
packages/taro-runtime/src/dom/style_properties.ts styleProperties 数组中新增 'backdropFilter' 属性。

Assessment against linked issues

Objective Addressed Explanation
内联样式中 backdropFilter 属性丢失问题修复 (#17464)

Suggested reviewers

  • Single-Dancer

Poem

小兔敲敲键盘跳,
backdropFilter 新添好;
透明模糊轻轻罩,
样式不再被丢掉。
代码一行春风到,
前端世界更美妙!
🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 873ff67 and 4f11a9f.

📒 Files selected for processing (1)
  • packages/taro-runtime/src/dom/style_properties.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/taro-runtime/src/dom/style_properties.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot requested a review from Single-Dancer April 17, 2025 03:50
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.37%. Comparing base (cffe105) to head (4f11a9f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #17553    +/-   ##
========================================
  Coverage   58.37%   58.37%            
========================================
  Files         469      469            
  Lines       27230    27230            
  Branches     5738     5962   +224     
========================================
  Hits        15895    15895            
+ Misses       9874     9845    -29     
- Partials     1461     1490    +29     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Apr 19, 2025
@Single-Dancer Single-Dancer added this to the 4.0.13 milestone Apr 24, 2025
- 在 styleProperties 数组中添加了 'backdropFilter' 属性
- 这个修改增加了小程序行内样式对 backdrop-filter CSS 属性的支持
@Single-Dancer Single-Dancer merged commit bd457b6 into NervJS:main Apr 27, 2025
24 checks passed
This was referenced May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

内联样式中使用 backdropFilter 会丢失
2 participants