Skip to content

Make deploy accounts transactions nice #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rianhughes opened this issue Oct 3, 2023 · 5 comments · May be fixed by #706
Open

Make deploy accounts transactions nice #381

rianhughes opened this issue Oct 3, 2023 · 5 comments · May be fixed by #706
Labels
help wanted Help from collaborators will be appreciated

Comments

@rianhughes
Copy link
Contributor

We should add a method to let users deploy accounts using the default UDC etc. Check other SDKs for inspiration

@rianhughes rianhughes changed the title Make deploying accounts transactions nice Make deploy accounts transactions nice Oct 3, 2023
@rianhughes rianhughes moved this to 📋 Backlog in [Nubia] Starknet.go Oct 3, 2023
@danielcdz
Copy link

@rianhughes @thiagodeev Hello! With some guidance and context, I can help you guys with this one

@thiagodeev
Copy link
Collaborator

Hi @danielcdz, sorry for the delay.
Thanks again for the help!

If you take a look at the examples folder, you'll see the deployContractUDC example, showing how to deploy a contract via the UDC contract (ref about the UDC).
You'll notice that the example shows a somewhat hard and manual way of doing this, so the proposal of this issue is to create a function/method to help the user deploy contracts via UDC, abstracting a lot of the hard work (similar to the BuildAndSendInvokeTxn method, that abstracts the hard work of building Invoke txns). You can take a look at this starknet.py example to learn more: https://starknetpy.readthedocs.io/en/latest/guide/deploying_contracts.html

@danielcdz
Copy link

@thiagodeev sorry for the delay here, I'll be working on this this week, hope to open a draft PR asap, again, thanks for the opportunity and the clarifications

@danielcdz danielcdz linked a pull request Apr 23, 2025 that will close this issue
@thiagodeev thiagodeev added the help wanted Help from collaborators will be appreciated label Apr 25, 2025
@HACKER097
Copy link

Hi! I noticed PR #706 has been dormant for a while. Would it be alright if I picked this up and opened a fresh PR based on the original intent, or continued from there if preferred?

@thiagodeev
Copy link
Collaborator

Hey @HACKER097, thanks!
You can create a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Help from collaborators will be appreciated
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants