-
Notifications
You must be signed in to change notification settings - Fork 134
Added DeployContractUDC to improve contract deployment experience. #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @HACKER097, congrats on your first PR! |
I wasn't able to create a test on devnet because the ABI of the UDC contract differs from the one on testnet, specifically, the function For now, I've written a test that runs on testnet. It uses hardcoded testnet keys and an RPC URL, similar to the TestSendDeclareTxn test. While I'm not sure if that's acceptable, it does keep the test simpler. Let me know if this approach is okay, and I'll go ahead and push the changes. |
Hey @HACKER097, sorry for the delay. Sure! You can push the changes, so I can take a look at the code |
I have pushed the test. As for the devnet discrepancy, this is how I came across it: Run the testnet
Use provided address for testing
Check abi
|
Hey @HACKER097! |
About your issue with devnet, which version are you using? |
@thiagodeev I have created pr #760 as requested, closing this one. |
Addresses issue #381.
Implementation details:
DeployContractUDC
method toaccount/account.go
account/transaction.go
examples/deployContractUDC/main.go
to use DeployContractUDCFirst crypto PR, looking forward to feedback :)