Skip to content

Fixing Typos and Improving Consistency #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Hopium21
Copy link

@Hopium21 Hopium21 commented Mar 2, 2025

  1. "aproximately" → "approximately"
    Old: aproximately
    New: approximately
    Reason: "Aproximately" was a misspelling. The correct word is "approximately."
    File: examples/deployContractUDC/main.go
  2. "1. Rename" → "1. Renaming"
    Old: 1. Rename the ".env.template" file located at the root of the "examples" folder to ".env"
    New: 1. Renaming the ".env.template" file located at the root of the "examples" folder to ".env"
    Reason: Changed "Rename" to "Renaming" for consistency with the other step format (present continuous action).
    File: examples/deployContractUDC/README.md
  3. "succesful" → "successful"
    Old: succesful
    New: successful
    Reason: "Succesful" was a typo; the correct spelling is "successful."
    File: examples/deployContractUDC/main.go

Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hopium21! Thanks. A few requests

@@ -1,12 +1,12 @@
This example deploys an [ERC20](https://docs.openzeppelin.com/contracts-cairo/0.8.1/erc20) token using the [UDC (Universal Deployer Contract)](https://docs.starknet.io/architecture-and-concepts/accounts/universal-deployer/) smart contract.

Steps:
1. Rename the ".env.template" file located at the root of the "examples" folder to ".env"
1. Renaming the ".env.template" file located at the root of the "examples" folder to ".env"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an error, it's intentional. Please revert it

The transaction hash and status will be returned at the end of the execution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here?

@Hopium21
Copy link
Author

@thiagodeev
Let's roll!

@thiagodeev
Copy link
Collaborator

Hey @Hopium21, sorry for the delay.
Could you solve the conflicts in your PR? Thanks!

@thiagodeev thiagodeev added the question Further information is requested label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants