-
Notifications
You must be signed in to change notification settings - Fork 134
Fixing Typos and Improving Consistency #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Hopium21! Thanks. A few requests
examples/deployContractUDC/README.md
Outdated
@@ -1,12 +1,12 @@ | |||
This example deploys an [ERC20](https://docs.openzeppelin.com/contracts-cairo/0.8.1/erc20) token using the [UDC (Universal Deployer Contract)](https://docs.starknet.io/architecture-and-concepts/accounts/universal-deployer/) smart contract. | |||
|
|||
Steps: | |||
1. Rename the ".env.template" file located at the root of the "examples" folder to ".env" | |||
1. Renaming the ".env.template" file located at the root of the "examples" folder to ".env" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an error, it's intentional. Please revert it
The transaction hash and status will be returned at the end of the execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here?
@thiagodeev |
Hey @Hopium21, sorry for the delay. |
Old: aproximately
New: approximately
Reason: "Aproximately" was a misspelling. The correct word is "approximately."
File: examples/deployContractUDC/main.go
Old: 1. Rename the ".env.template" file located at the root of the "examples" folder to ".env"
New: 1. Renaming the ".env.template" file located at the root of the "examples" folder to ".env"
Reason: Changed "Rename" to "Renaming" for consistency with the other step format (present continuous action).
File: examples/deployContractUDC/README.md
Old: succesful
New: successful
Reason: "Succesful" was a typo; the correct spelling is "successful."
File: examples/deployContractUDC/main.go