-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Lua ssh 7607 v9 #13084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua ssh 7607 v9 #13084
Conversation
Completes commit 1206c1c
To enable easily hooks for rust app-layers such as SSH
Allows signature like `alert ssh:request_banner_done`
Ticket: 7607
Ticket: 7607
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13084 +/- ##
==========================================
- Coverage 82.78% 82.63% -0.15%
==========================================
Files 985 985
Lines 272547 272533 -14
==========================================
- Hits 225617 225218 -399
- Misses 46930 47315 +385
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Information: QA ran without warnings. Pipeline 25774 |
ssh | ||
^^^ | ||
|
||
Available states are listed in `ssh-hooks`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a link? cc @jufajardini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, I messed it
@jufajardini how do I test the rendering ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In doc/userguide
you can do make html
. You will need Sphinx installed though. For an example of the Ubuntu dependencies, see https://github.com/OISF/suricata/blob/master/.github/workflows/docs.yml, or for Fedora/RHEL: https://github.com/OISF/suricata/blob/master/.github/workflows/builds.yml#L68
Next in #13090 |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7607
Describe changes:
SV_BRANCH=OISF/suricata-verify#2455
#13077 with needed rebase and better doc according to review
Still to do afterwards :