-
Notifications
You must be signed in to change notification settings - Fork 131
Feature/tp/add speed bumps #448 #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Renaming of branch done to stay compliant with branching naming convention |
I think this needs to be rebased on current master, since it includes lots of Wheel Data content which might conflict. Other than that I think this looks good to me... |
osi_object.proto
Outdated
// | ||
// \note OSI uses singular instead of plural for repeated field names. | ||
// | ||
repeated double assigned_lane_percentage = 6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this be calculated out of base in comparison to lane width?
Or did I miss the point here? => Then a better description would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output from CCB - 03.03.2021:
- Move repeated Identifier assigned_lane_id and repeated double assigned_lane_percentage to another pull request and consider adding them to a new "Static Object Classification" (see Moving Object Classification)
6fc328d
to
77678a6
Compare
Output from CCB 03.03.2021:
|
Will be merged to master once 3.3.0 is cut, i.e. after 2021-03-17 TSC decision. |
** Output of CCB 12.05.2021**:
|
77678a6
to
9987c3d
Compare
Signed-off-by: Schloemicher, Thomas AVL,AT <[email protected]>
2f943f6
to
25320e7
Compare
Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
Add a description of the changes proposed in the pull request.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!