Feature/tp/add speed bumps #448 #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0815-code
added
FeatureRequest
|
Renaming of branch done to stay compliant with branching naming convention |
|
I think this needs to be rebased on current master, since it includes lots of Wheel Data content which might conflict. Other than that I think this looks good to me... |
0815-code
added
the
ReadyForCCBReview
osi_object.proto
Outdated
| // | ||
| // \note OSI uses singular instead of plural for repeated field names. | ||
| // | ||
| repeated double assigned_lane_percentage = 6; |
There was a problem hiding this comment.
Can't this be calculated out of base in comparison to lane width?
Or did I miss the point here? => Then a better description would be good
There was a problem hiding this comment.
Output from CCB - 03.03.2021:
- Move repeated Identifier assigned_lane_id and repeated double assigned_lane_percentage to another pull request and consider adding them to a new "Static Object Classification" (see Moving Object Classification)
pmai
force-pushed
the
feature/tp/add_speed_bumps_#448
branch
from
6fc328d to
77678a6
Compare
|
Output from CCB 03.03.2021:
|
kmeids
added
ReadyToMerge
|
Will be merged to master once 3.3.0 is cut, i.e. after 2021-03-17 TSC decision. |
pmai
approved these changes
Mar 3, 2021
0815-code
added
the
ReadyForCCBReview
|
** Output of CCB 12.05.2021**:
|
kmeids
removed
the
ReadyForCCBReview
pmai
force-pushed
the
feature/tp/add_speed_bumps_#448
branch
from
77678a6 to
9987c3d
Compare
Signed-off-by: Schloemicher, Thomas AVL,AT <[email protected]>
pmai
force-pushed
the
feature/tp/add_speed_bumps_#448
branch
from
2f943f6 to
25320e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
Add a description of the changes proposed in the pull request.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!