Skip to content

Feature/tp/add speed bumps #448 #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

0815-code
Copy link
Contributor

@0815-code 0815-code commented Feb 12, 2021

Reference to a related issue in the repository

Add a reference to a related issue in the repository.

Add a description

Add a description of the changes proposed in the pull request.

Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@0815-code 0815-code self-assigned this Feb 12, 2021
@0815-code 0815-code added FeatureRequest Proposals which enhance the interface or add additional features. TrafficParticipants The group in the ASAM development project working on traffic participants. labels Feb 12, 2021
@0815-code 0815-code linked an issue Feb 12, 2021 that may be closed by this pull request
@0815-code
Copy link
Contributor Author

Renaming of branch done to stay compliant with branching naming convention

@pmai
Copy link
Contributor

pmai commented Feb 12, 2021

I think this needs to be rebased on current master, since it includes lots of Wheel Data content which might conflict.

Other than that I think this looks good to me...

@0815-code 0815-code added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Feb 24, 2021
osi_object.proto Outdated
//
// \note OSI uses singular instead of plural for repeated field names.
//
repeated double assigned_lane_percentage = 6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be calculated out of base in comparison to lane width?
Or did I miss the point here? => Then a better description would be good

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output from CCB - 03.03.2021:

  1. Move repeated Identifier assigned_lane_id and repeated double assigned_lane_percentage to another pull request and consider adding them to a new "Static Object Classification" (see Moving Object Classification)

@pmai pmai force-pushed the feature/tp/add_speed_bumps_#448 branch from 6fc328d to 77678a6 Compare March 3, 2021 11:15
@kmeids
Copy link

kmeids commented Mar 3, 2021

Output from CCB 03.03.2021:

  1. Only TYPE_SPEED_BUMP = 17 will be considered in this pull request.
  2. @pmai will merge this to master.

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Mar 3, 2021
@pmai
Copy link
Contributor

pmai commented Mar 3, 2021

Will be merged to master once 3.3.0 is cut, i.e. after 2021-03-17 TSC decision.

@0815-code 0815-code added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 30, 2021
@kmeids
Copy link

kmeids commented May 12, 2021

** Output of CCB 12.05.2021**:

  1. @pmai to do the merge after switching to Github actions.

@kmeids kmeids removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label May 12, 2021
@pmai pmai force-pushed the feature/tp/add_speed_bumps_#448 branch from 77678a6 to 9987c3d Compare May 12, 2021 11:48
Signed-off-by: Schloemicher, Thomas AVL,AT <[email protected]>
@pmai pmai force-pushed the feature/tp/add_speed_bumps_#448 branch from 2f943f6 to 25320e7 Compare June 22, 2021 20:56
@pmai pmai merged commit c500a7f into master Jun 22, 2021
@pmai pmai added this to the V3.4.0 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. TrafficParticipants The group in the ASAM development project working on traffic participants.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed bumps missing as type in stationary object class
4 participants