-
Notifications
You must be signed in to change notification settings - Fork 90
Dockerize #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize #2363
Conversation
Great pull request! However, the deployment fails:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build and run the docker container successfully. I didn't set up networking, so I don't know whether that works, but I was able to get to DSKDMP and list the files in the "." directory. I was able to start up ITS and see messages from the operator console. So I'm guessing it would work just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into why deployment fails.
I see! I naively used the name of the git repo as name for the Docker repo. My first impulse is to just lowercase said name, but let me take a look at the requirements, just in case there are other limitations (like no hyphens) |
Aha. Looks like repos must follow the rule
(Taken from these docs) Cool, in that case using the name of the repo in lowercase should work. Let me fix that. |
@eswenson1 Great news! Thanks for trying it out :-) |
Hmmm. I don't seem to be able to add the new commits to this pull request. Weird, I would have sworn I did something like that in the past. |
Done - new pull request: #2365 |
dependencies.sh
so it works in Ubuntu 24.04KLH10
,SIMH
,pdp10-ka
,pdp10-kl
andpdp10-ks
.lisp.tcl
because half of the time the workflow would fail to build the image forKLH10