Skip to content

Dockerize #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Dockerize #2363

wants to merge 4 commits into from

Conversation

mfgamallo
Copy link

  • Fix dependencies.sh so it works in Ubuntu 24.04
  • Generate a Docker image per emulator: KLH10, SIMH, pdp10-ka, pdp10-kl and pdp10-ks.
  • Increase timeout in lisp.tcl because half of the time the workflow would fail to build the image for KLH10
  • Push images to GitHub Packages <-- WARNING! I only tested this in my repo!

@larsbrinkhoff
Copy link
Member

Great pull request! However, the deployment fails:

ERROR: invalid tag "ghcr.io/PDP-10/its-klh10:e19bd829e50d9cd9b0f63d740ae42cc1ca2add7d": repository name must be lowercase

Copy link
Member

@eswenson1 eswenson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build and run the docker container successfully. I didn't set up networking, so I don't know whether that works, but I was able to get to DSKDMP and list the files in the "." directory. I was able to start up ITS and see messages from the operator console. So I'm guessing it would work just fine.

Copy link
Member

@larsbrinkhoff larsbrinkhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into why deployment fails.

@mfgamallo
Copy link
Author

I see! I naively used the name of the git repo as name for the Docker repo. My first impulse is to just lowercase said name, but let me take a look at the requirements, just in case there are other limitations (like no hyphens)

@mfgamallo
Copy link
Author

Aha. Looks like repos must follow the rule

Only contain lowercase letters, numbers, hyphens (-), and underscores (_)

(Taken from these docs)

Cool, in that case using the name of the repo in lowercase should work. Let me fix that.

@mfgamallo
Copy link
Author

@eswenson1 Great news! Thanks for trying it out :-)

@mfgamallo
Copy link
Author

Hmmm. I don't seem to be able to add the new commits to this pull request. Weird, I would have sworn I did something like that in the past.
Well, never mind. I can close this PR and open a new one.

@mfgamallo
Copy link
Author

Done - new pull request: #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants