-
Notifications
You must be signed in to change notification settings - Fork 0
chore: remove redundant deploy jobs from CircleCI config #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit eliminates the deploy jobs for production and verdaccio from the CircleCI configuration, streamlining the workflow. Additionally, it introduces comments for better clarity on the workflow requirements.
This commit removes the 'rsp-xlarge' executor from multiple jobs in the CircleCI configuration, streamlining the setup and potentially improving resource allocation during builds.
This commit introduces the 'rsp' executor to various jobs in the CircleCI configuration, ensuring consistent resource allocation and improving build performance across the pipeline.
…obs and updating executor This commit removes multiple storybook jobs from the CircleCI configuration and consolidates them under a single executor, improving clarity and resource management. The 'typecheck-docs' job is also updated to use the 'rsp' executor, ensuring consistency across the pipeline.
This commit eliminates the test jobs for versions 16, 17, and 19 from the CircleCI configuration, streamlining the workflow and reducing redundancy. The remaining jobs are updated to maintain clarity and efficiency in the testing process.
…ation This commit further streamlines the CircleCI configuration by removing the install jobs for versions 16, 17, and 19, enhancing workflow efficiency and reducing redundancy in the build process.
… install jobs This commit continues to enhance the CircleCI configuration by eliminating the install jobs for versions 16, 17, and 19, further reducing redundancy and improving workflow efficiency.
This commit modifies the CircleCI configuration to replace the 'rsp-large' executor with the 'rsp' executor across all jobs, enhancing consistency and potentially improving resource management in the build process.
This commit modifies the test commands in package.json to include the --runInBand option for both the 'test' and 'ci-test' scripts, ensuring tests run sequentially. This change aims to enhance performance and stability during testing, particularly in CI environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we plan to keep using CircleCI, or is this just a temporary setup?
The idea is that someday we don't need this fork at all so deviating much from upstream didn't seem like a good idea. Also the code is public so any service should be fine as long as it works. If we see any issue, we can always revisit this in future. Does this make sense? |
* chore: remove redundant deploy jobs from CircleCI config This commit eliminates the deploy jobs for production and verdaccio from the CircleCI configuration, streamlining the workflow. Additionally, it introduces comments for better clarity on the workflow requirements. * chore: remove rsp-xlarge executor from CircleCI config jobs This commit removes the 'rsp-xlarge' executor from multiple jobs in the CircleCI configuration, streamlining the setup and potentially improving resource allocation during builds. * chore: add 'rsp' executor to multiple CircleCI jobs This commit introduces the 'rsp' executor to various jobs in the CircleCI configuration, ensuring consistent resource allocation and improving build performance across the pipeline. * chore: streamline CircleCI configuration by consolidating storybook jobs and updating executor This commit removes multiple storybook jobs from the CircleCI configuration and consolidates them under a single executor, improving clarity and resource management. The 'typecheck-docs' job is also updated to use the 'rsp' executor, ensuring consistency across the pipeline. * chore: remove obsolete test jobs from CircleCI configuration This commit eliminates the test jobs for versions 16, 17, and 19 from the CircleCI configuration, streamlining the workflow and reducing redundancy. The remaining jobs are updated to maintain clarity and efficiency in the testing process. * chore: remove additional obsolete install jobs from CircleCI configuration This commit further streamlines the CircleCI configuration by removing the install jobs for versions 16, 17, and 19, enhancing workflow efficiency and reducing redundancy in the build process. * chore: further streamline CircleCI configuration by removing obsolete install jobs This commit continues to enhance the CircleCI configuration by eliminating the install jobs for versions 16, 17, and 19, further reducing redundancy and improving workflow efficiency. * chore: update CircleCI configuration to use 'rsp' executor for all jobs This commit modifies the CircleCI configuration to replace the 'rsp-large' executor with the 'rsp' executor across all jobs, enhancing consistency and potentially improving resource management in the build process. * chore: update test commands in package.json for improved performance This commit modifies the test commands in package.json to include the --runInBand option for both the 'test' and 'ci-test' scripts, ensuring tests run sequentially. This change aims to enhance performance and stability during testing, particularly in CI environments.
This PR removes the tests that are not required by us and makes changes so that tests pass on CI.