Skip to content

chore: rename react-aria to "@react-aria-nutrient/*" #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2025

Conversation

ritz078
Copy link
Collaborator

@ritz078 ritz078 commented Apr 4, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@ritz078 ritz078 changed the title Rename react-aria to "@react-aria-nutrient/*" chore: rename react-aria to "@react-aria-nutrient/*" Apr 4, 2025
@ritz078 ritz078 marked this pull request as ready for review April 4, 2025 18:06
@ritz078 ritz078 self-assigned this Apr 4, 2025
Copy link

@iperzic iperzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not possible to achieve using alias? Not only that seems like a more robust way to handle this, but it could save us potential conflicts whenever upstream import changes

@ritz078
Copy link
Collaborator Author

ritz078 commented Apr 7, 2025

@iperzic How will you alias package name and publish it to npm ?

@darktasevski
Copy link

Just wondering, have we considered using company name as a scope for npm packages? For example @nutrient/react-aria.

@ritz078
Copy link
Collaborator Author

ritz078 commented Apr 8, 2025

Just wondering, have we considered using company name as a scope for npm packages? For example @nutrient/react-aria.

@darktasevski It's not available 😢 https://www.npmjs.com/~nutrient otherwise we would have grabbed it for our main SDK itself.

@darktasevski
Copy link

Just wondering, have we considered using company name as a scope for npm packages? For example @nutrient/react-aria.

@darktasevski It's not available 😢 https://www.npmjs.com/~nutrient otherwise we would have grabbed it for our main SDK itself.

Well, that's disappointing :/

@iperzic
Copy link

iperzic commented Apr 9, 2025

How will you alias package name and publish it to npm ?

I referred to the fact that we still have to publish under a different name, but we don't have to change code occurrences of import, because it would be an alias that points original name, to our name.

@ritz078
Copy link
Collaborator Author

ritz078 commented Apr 9, 2025

I referred to the fact that we still have to publish under a different name, but we don't have to change code occurrences of import, because it would be an alias that points original name, to our name.

The amount of custom code required to make imports work for storybook, jest and yarn might not be worth it. Brute force was just a faster approach. One thing we can do without changing much is keep the directory name same as earlier.

@iperzic
Copy link

iperzic commented Apr 9, 2025

Yeah, that would help somewhat.

TBH, I was mostly inspired for this by the other PR where my browser would completely freeze when reviewing 1993 files, so figured that it can be simplifies

@ritz078 ritz078 merged commit d6c0605 into ritesh/rename-packages Apr 10, 2025
10 checks passed
ritz078 added a commit that referenced this pull request Apr 10, 2025
* Rename packages

* chore: update @react-aria-nutrient/aria-modal-polyfill version to 3.7.13 in package.json

* chore: update @react-aria-nutrient/aria-modal-polyfill version in yarn.lock to 3.7.13

* chore: update @react-aria-nutrient/aria-modal-polyfill version to ^3.7.13 in package.json

* chore: replace @react-aria-nutrient/aria-modal-polyfill with @react-aria/aria-modal-polyfill in package.json and yarn.lock

* chore: update dependencies to use @react-aria/interactions and @react-aria/visually-hidden in package.json and yarn.lock

* chore: remove 'docs' job from CircleCI workflow and update dependencies for comment job

* chore: remove 'docs' and 'v-docs' jobs from CircleCI configuration to streamline workflow

* fixes

* fix: update import paths from @react-aria-nutrient to @react-aria for numberfield and dnd components

* fix: update Makefile to correct package paths by replacing @react-aria-nutrient with @react-aria

* fix: update linting script to replace @react-aria-nutrient/example-theme with @react-aria/example-theme

* chore: rename react-aria to "@react-aria-nutrient/*" (#5)

* Rename react-aria to "@react-aria-nutrient/*"

* chore: update dependencies to include @react-aria-nutrient/react-aria version ^3.38.1 in package.json and yarn.lock

* fix: update path for react-aria components to remove namespace prefix

* fix: update test to reflect new namespace for react-aria components

* fix: update documentation paths to include aria-nutrient namespace in package.json

* fixes
ritz078 added a commit that referenced this pull request Apr 10, 2025
* Rename packages

* chore: update @react-aria-nutrient/aria-modal-polyfill version to 3.7.13 in package.json

* chore: update @react-aria-nutrient/aria-modal-polyfill version in yarn.lock to 3.7.13

* chore: update @react-aria-nutrient/aria-modal-polyfill version to ^3.7.13 in package.json

* chore: replace @react-aria-nutrient/aria-modal-polyfill with @react-aria/aria-modal-polyfill in package.json and yarn.lock

* chore: update dependencies to use @react-aria/interactions and @react-aria/visually-hidden in package.json and yarn.lock

* chore: remove 'docs' job from CircleCI workflow and update dependencies for comment job

* chore: remove 'docs' and 'v-docs' jobs from CircleCI configuration to streamline workflow

* fixes

* fix: update import paths from @react-aria-nutrient to @react-aria for numberfield and dnd components

* fix: update Makefile to correct package paths by replacing @react-aria-nutrient with @react-aria

* fix: update linting script to replace @react-aria-nutrient/example-theme with @react-aria/example-theme

* chore: rename react-aria to "@react-aria-nutrient/*" (#5)

* Rename react-aria to "@react-aria-nutrient/*"

* chore: update dependencies to include @react-aria-nutrient/react-aria version ^3.38.1 in package.json and yarn.lock

* fix: update path for react-aria components to remove namespace prefix

* fix: update test to reflect new namespace for react-aria components

* fix: update documentation paths to include aria-nutrient namespace in package.json

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants