-
Notifications
You must be signed in to change notification settings - Fork 0
chore: rename react-aria to "@react-aria-nutrient/*" #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this not possible to achieve using alias? Not only that seems like a more robust way to handle this, but it could save us potential conflicts whenever upstream import changes
@iperzic How will you alias package name and publish it to npm ? |
Just wondering, have we considered using company name as a scope for npm packages? For example |
@darktasevski It's not available 😢 https://www.npmjs.com/~nutrient otherwise we would have grabbed it for our main SDK itself. |
Well, that's disappointing :/ |
I referred to the fact that we still have to publish under a different name, but we don't have to change code occurrences of import, because it would be an alias that points original name, to our name. |
The amount of custom code required to make imports work for storybook, jest and yarn might not be worth it. Brute force was just a faster approach. One thing we can do without changing much is keep the directory name same as earlier. |
Yeah, that would help somewhat. TBH, I was mostly inspired for this by the other PR where my browser would completely freeze when reviewing 1993 files, so figured that it can be simplifies |
…labs/react-spectrum into ritesh/react-aria-renaming
* Rename packages * chore: update @react-aria-nutrient/aria-modal-polyfill version to 3.7.13 in package.json * chore: update @react-aria-nutrient/aria-modal-polyfill version in yarn.lock to 3.7.13 * chore: update @react-aria-nutrient/aria-modal-polyfill version to ^3.7.13 in package.json * chore: replace @react-aria-nutrient/aria-modal-polyfill with @react-aria/aria-modal-polyfill in package.json and yarn.lock * chore: update dependencies to use @react-aria/interactions and @react-aria/visually-hidden in package.json and yarn.lock * chore: remove 'docs' job from CircleCI workflow and update dependencies for comment job * chore: remove 'docs' and 'v-docs' jobs from CircleCI configuration to streamline workflow * fixes * fix: update import paths from @react-aria-nutrient to @react-aria for numberfield and dnd components * fix: update Makefile to correct package paths by replacing @react-aria-nutrient with @react-aria * fix: update linting script to replace @react-aria-nutrient/example-theme with @react-aria/example-theme * chore: rename react-aria to "@react-aria-nutrient/*" (#5) * Rename react-aria to "@react-aria-nutrient/*" * chore: update dependencies to include @react-aria-nutrient/react-aria version ^3.38.1 in package.json and yarn.lock * fix: update path for react-aria components to remove namespace prefix * fix: update test to reflect new namespace for react-aria components * fix: update documentation paths to include aria-nutrient namespace in package.json * fixes
* Rename packages * chore: update @react-aria-nutrient/aria-modal-polyfill version to 3.7.13 in package.json * chore: update @react-aria-nutrient/aria-modal-polyfill version in yarn.lock to 3.7.13 * chore: update @react-aria-nutrient/aria-modal-polyfill version to ^3.7.13 in package.json * chore: replace @react-aria-nutrient/aria-modal-polyfill with @react-aria/aria-modal-polyfill in package.json and yarn.lock * chore: update dependencies to use @react-aria/interactions and @react-aria/visually-hidden in package.json and yarn.lock * chore: remove 'docs' job from CircleCI workflow and update dependencies for comment job * chore: remove 'docs' and 'v-docs' jobs from CircleCI configuration to streamline workflow * fixes * fix: update import paths from @react-aria-nutrient to @react-aria for numberfield and dnd components * fix: update Makefile to correct package paths by replacing @react-aria-nutrient with @react-aria * fix: update linting script to replace @react-aria-nutrient/example-theme with @react-aria/example-theme * chore: rename react-aria to "@react-aria-nutrient/*" (#5) * Rename react-aria to "@react-aria-nutrient/*" * chore: update dependencies to include @react-aria-nutrient/react-aria version ^3.38.1 in package.json and yarn.lock * fix: update path for react-aria components to remove namespace prefix * fix: update test to reflect new namespace for react-aria components * fix: update documentation paths to include aria-nutrient namespace in package.json * fixes
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: